Skip to content

Commit 4ea0cdc

Browse files
author
Charles Li
committed
Revert "Trigger unit tests for docker images upload workflow"
This reverts commit 0b6df4f.
1 parent 496ed40 commit 4ea0cdc

2 files changed

Lines changed: 5 additions & 149 deletions

File tree

.github/workflows/UploadDockerImages.yml

Lines changed: 5 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# This workflow builds and pushes MaxText images for both TPU and GPU devices.
1616
# It runs automatically daily at 12am UTC, on Pull Requests, or manually via Workflow Dispatch.
1717

18-
name: Build and Test Images
18+
name: Build Images
1919

2020
on:
2121
schedule:
@@ -32,11 +32,6 @@ on:
3232
- all
3333
- tpu
3434
- gpu
35-
for_dev_test:
36-
description: 'For development test purpose. All images will be added a -test suffix'
37-
required: false
38-
type: boolean
39-
default: false
4035

4136
permissions:
4237
contents: read
@@ -47,7 +42,6 @@ jobs:
4742
outputs:
4843
maxtext_sha: ${{ steps.vars.outputs.maxtext_sha }}
4944
image_date: ${{ steps.vars.outputs.image_date }}
50-
image_suffix: ${{ steps.vars.outputs.image_suffix }}
5145
steps:
5246
- name: Checkout MaxText
5347
uses: actions/checkout@v5
@@ -61,13 +55,6 @@ jobs:
6155
# Image date
6256
echo "image_date=$(date +%Y-%m-%d)" >> $GITHUB_OUTPUT
6357
64-
# If for_dev_test is true, set suffix to -test, otherwise empty
65-
if [[ "${{ github.event.inputs.for_dev_test }}" == "true" ]]; then
66-
echo "image_suffix=-test" >> $GITHUB_OUTPUT
67-
else
68-
echo "image_suffix=" >> $GITHUB_OUTPUT
69-
fi
70-
7158
tpu-pre-training:
7259
name: ${{ matrix.image_name }}
7360
needs: setup
@@ -85,7 +72,7 @@ jobs:
8572
dockerfile: ./dependencies/dockerfiles/maxtext_tpu_dependencies.Dockerfile
8673
uses: ./.github/workflows/build_and_push_docker_image.yml
8774
with:
88-
image_name: ${{ matrix.image_name }}${{ needs.setup.outputs.image_suffix }}
75+
image_name: ${{ matrix.image_name }}
8976
device: ${{ matrix.device }}
9077
build_mode: ${{ matrix.build_mode }}
9178
dockerfile: ${{ matrix.dockerfile }}
@@ -109,13 +96,14 @@ jobs:
10996
dockerfile: ./dependencies/dockerfiles/maxtext_post_training_local_dependencies.Dockerfile
11097
uses: ./.github/workflows/build_and_push_docker_image.yml
11198
with:
112-
image_name: ${{ matrix.image_name }}${{ needs.setup.outputs.image_suffix }}
99+
image_name: ${{ matrix.image_name }}
113100
device: ${{ matrix.device }}
114101
build_mode: ${{ matrix.build_mode }}
115102
dockerfile: ${{ matrix.dockerfile }}
116103
maxtext_sha: ${{ needs.setup.outputs.maxtext_sha }}
117104
image_date: ${{ needs.setup.outputs.image_date }}
118105
base_image: gcr.io/tpu-prod-env-multipod/maxtext_jax_stable:${{ needs.setup.outputs.image_date }}
106+
is_post_training: true
119107

120108
gpu-pre-training:
121109
name: ${{ matrix.image_name }}
@@ -134,48 +122,9 @@ jobs:
134122
dockerfile: ./dependencies/dockerfiles/maxtext_gpu_dependencies.Dockerfile
135123
uses: ./.github/workflows/build_and_push_docker_image.yml
136124
with:
137-
image_name: ${{ matrix.image_name }}${{ needs.setup.outputs.image_suffix }}
125+
image_name: ${{ matrix.image_name }}
138126
device: ${{ matrix.device }}
139127
build_mode: ${{ matrix.build_mode }}
140128
dockerfile: ${{ matrix.dockerfile }}
141129
maxtext_sha: ${{ needs.setup.outputs.maxtext_sha }}
142130
image_date: ${{ needs.setup.outputs.image_date }}
143-
144-
# TEST JOBS
145-
pre-training-tpu-tests:
146-
needs: [setup, tpu-pre-training]
147-
strategy:
148-
fail-fast: false
149-
matrix:
150-
image: [maxtext_jax_stable, maxtext_jax_nightly]
151-
uses: ./.github/workflows/test_and_tag_docker_image.yml
152-
with:
153-
image_name: ${{ matrix.image }}${{ needs.setup.outputs.image_suffix }}
154-
image_date: ${{ needs.setup.outputs.image_date }}
155-
test_mode: tpu-pre-training
156-
157-
post-training-tpu-tests:
158-
needs: [setup, tpu-post-training]
159-
strategy:
160-
fail-fast: false
161-
matrix:
162-
image: [maxtext_post_training_stable, maxtext_post_training_nightly]
163-
uses: ./.github/workflows/test_and_tag_docker_image.yml
164-
with:
165-
image_name: ${{ matrix.image }}${{ needs.setup.outputs.image_suffix }}
166-
image_date: ${{ needs.setup.outputs.image_date }}
167-
test_mode: tpu-post-training
168-
169-
170-
pre-training-gpu-tests:
171-
needs: [setup, gpu-pre-training]
172-
strategy:
173-
fail-fast: false
174-
matrix:
175-
image: [maxtext_gpu_jax_stable, maxtext_gpu_jax_nightly]
176-
uses: ./.github/workflows/test_and_tag_docker_image.yml
177-
with:
178-
image_name: ${{ matrix.image }}${{ needs.setup.outputs.image_suffix }}
179-
image_date: ${{ needs.setup.outputs.image_date }}
180-
test_mode: gpu-pre-training
181-

.github/workflows/test_and_tag_docker_image.yml

Lines changed: 0 additions & 93 deletions
This file was deleted.

0 commit comments

Comments
 (0)