Skip to content

Commit db53b4e

Browse files
committed
Fix Codecov setup
Minor fixes in an attempt to make code coverage work.
1 parent f27ac67 commit db53b4e

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

.github/workflows/run_tests_against_package.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,4 +130,4 @@ jobs:
130130
with:
131131
token: ${{ secrets.CODECOV_TOKEN }}
132132
# If scheduled, upload to BOTH flags. If PR, upload ONLY to regular.
133-
flags: ${{ inputs.is_scheduled_run == 'true' && 'regular,scheduled' || 'regular' }}
133+
flags: ${{ inputs.is_scheduled_run == 'true' && 'scheduled' || 'regular' }}

codecov.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,17 @@
1919
# Without it, PRs would show a significant coverage drop as they would 'overwrite' the full-suite results.
2020
#
2121
# Scheme:
22-
# - 'regular': Updated by every PR/Schedule. Used to evaluate 'patch' (new code) coverage.
23-
# - 'scheduled': Updated ONLY by scheduled full runs. Used to anchor 'project' (total health) coverage.
22+
# - 'regular': Updated by every PR. Used to evaluate 'patch' (new code) coverage.
23+
# - 'scheduled': Updated by scheduled full runs. Used to anchor 'project' (total health) coverage.
2424
# During PRs, the 'scheduled' flag is carried forward from the last full run on 'main' to keep the score stable.
2525

2626
# Exclude non-source code, deprecated and experimental folders from coverage tracking
2727
codecov:
2828
token: 35742a22-fb1f-4839-97ff-b54da5588689
29+
# By default file names in the coverage report will have their path in the file system, which in our
30+
# runners would be /__w/maxtext/maxtext/src/MaxText/* but Codecov expects src/MaxText/* so we need to fix the path
31+
fixes:
32+
- ".*/maxtext/src/::src/"
2933
ignore:
3034
- "src/MaxText/assets"
3135
- "src/MaxText/configs"

0 commit comments

Comments
 (0)