Skip to content

Commit 84bfda8

Browse files
committed
dmaengine: sdxi: context: sdxi_cxt_push_doorbell() comment tweaks
Remove the to-do; not clear there's much value there. Improve the barrier documentation. Signed-off-by: Nathan Lynch <nathan.lynch@amd.com>
1 parent 91724e3 commit 84bfda8

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

drivers/dma/sdxi/context.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -329,12 +329,7 @@ void sdxi_cxt_push_doorbell(struct sdxi_cxt *cxt, u64 index)
329329
{
330330
enum cxt_sts_state state = sdxi_cxt_sts_state(cxt->sq->cxt_sts);
331331

332-
/*
333-
* To do: cache doorbell values as they're written to
334-
* eliminate redundant doorbell writes.
335-
*/
336-
337-
/* Ensure write index is visible. */
332+
/* Ensure preceding write index increment is visible. */
338333
dma_wmb();
339334
sdxi_dbg(cxt->sdxi, "Ringing context %u (state = %s) doorbell: %llu\n",
340335
cxt->id, cxt_sts_state_str(state), index);

0 commit comments

Comments
 (0)