Skip to content

Commit c0aab2d

Browse files
committed
dmaengine: sdxi: context: Initialize admin cxt_sts in sdxi_admin_cxt_init()
Makes more sense to do it in here rather than up in the function activation routine. Ordering with respect to updating the context table also makes slightly more sense IMO. Signed-off-by: Nathan Lynch <nathan.lynch@amd.com>
1 parent 09ed767 commit c0aab2d

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/dma/sdxi/context.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -413,6 +413,8 @@ int sdxi_admin_cxt_init(struct sdxi_dev *sdxi)
413413
return -ENOMEM;
414414

415415
sq = cxt->sq;
416+
/* SDXI 1.0 4.1.8.4.b: Set CXT_STS.state to CXTV_RUN. */
417+
sq->cxt_sts->state = FIELD_PREP(SDXI_CXT_STS_STATE, CXTV_RUN);
416418
cxt->id = SDXI_ADMIN_CXT_ID;
417419
cxt->db = sdxi->dbs + cxt->id * sdxi->db_stride;
418420
ida_init(&cxt->akey_ida);

drivers/dma/sdxi/device.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -243,9 +243,6 @@ static int sdxi_fn_activate(struct sdxi_dev *sdxi)
243243
if (err)
244244
return err;
245245

246-
/* SDXI 1.0 4.1.8.4.b: Set CXT_STS.state to CXTV_RUN. */
247-
sdxi->admin_cxt->sq->cxt_sts->state = FIELD_PREP(SDXI_CXT_STS_STATE,
248-
CXTV_RUN);
249246
/*
250247
* SDXI 1.0 4.1.8.9: Set MMIO_CTL0.fn_gsr to GSRV_ACTIVE and
251248
* wait for MMIO_STS0.fn_gsv to reach GSV_ACTIVE or GSV_ERROR.

0 commit comments

Comments
 (0)