Skip to content

Commit f3da095

Browse files
committed
dmaengine: sdxi: context: SDXI_ADMIN_CXT_ID cleanup
* Move to context.c since it's not used elsewhere. * Cite the spec. We're not choosing index 0; the spec mandates it. Signed-off-by: Nathan Lynch <nathan.lynch@amd.com>
1 parent ed8aa6c commit f3da095

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

drivers/dma/sdxi/context.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,14 @@
2626

2727
#define DEFAULT_DESC_RING_ENTRIES 1024
2828

29+
enum {
30+
/*
31+
* The admin context always has ID 0. See SDXI 1.0 3.5
32+
* Administrative Context (Context 0).
33+
*/
34+
SDXI_ADMIN_CXT_ID = 0,
35+
};
36+
2937
/*
3038
* Free context and its resources. @cxt may be partially allocated but
3139
* must have ->sdxi set.
@@ -392,7 +400,7 @@ struct sdxi_cxt *sdxi_admin_cxt_init(struct sdxi_dev *sdxi)
392400
return NULL;
393401

394402
sq = cxt->sq;
395-
cxt->id = 0;
403+
cxt->id = SDXI_ADMIN_CXT_ID;
396404
cxt->db = sdxi->dbs + cxt->id * sdxi->db_stride;
397405
ida_init(&cxt->akey_ida);
398406
sdxi_ring_state_init(cxt->ring_state, &sq->cxt_sts->read_index,

drivers/dma/sdxi/context.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@ struct sdxi_cxt {
5151
struct sdxi_ring_state *ring_state;
5252
};
5353

54-
enum sdxi_cxt_id {
55-
SDXI_ADMIN_CXT_ID = 0,
56-
};
57-
5854
struct sdxi_cxt *sdxi_admin_cxt_init(struct sdxi_dev *sdxi);
5955
void sdxi_admin_cxt_exit(struct sdxi_cxt *cxt);
6056

0 commit comments

Comments
 (0)