Skip to content

Commit c540d59

Browse files
committed
CHG: optimze code
1 parent e5e7930 commit c540d59

8 files changed

Lines changed: 20 additions & 48 deletions

File tree

macOS/APIExample/Commons/GlobalSettings.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,14 @@ class GlobalSettings {
3636
static let shared = GlobalSettings()
3737
let resolutionSetting: SettingItem<Int> = SettingItem(
3838
selected: Configs.defaultResolutionIdx,
39-
options: Configs.Resolutions.enumerated().map({ (element: EnumeratedSequence<[Resolution]>.Iterator.Element) -> SettingItemOption<Int> in
40-
return SettingItemOption(idx: element.offset, label: element.element.name(), value: element.offset)
41-
})
39+
options: Configs.Resolutions.enumerated().map {
40+
SettingItemOption(idx: $0.offset, label: $0.element.name(), value: $0.offset)
41+
}
4242
)
4343
let fpsSetting: SettingItem<Int> = SettingItem(
4444
selected: Configs.defaultFpsIdx,
45-
options: Configs.Fps.enumerated().map({ (element: EnumeratedSequence<[Int]>.Iterator.Element) -> SettingItemOption<Int> in
46-
return SettingItemOption(idx: element.offset, label: "\(element.element)fps", value: element.offset)
47-
})
45+
options: Configs.Fps.enumerated().map {
46+
SettingItemOption(idx: $0.offset, label: "\($0.element)fps", value: $0.offset)
47+
}
4848
)
4949
}

macOS/APIExample/Examples/Advanced/CustomVideoRender/CustomVideoRender.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,11 @@ class CustomVideoRender: BaseViewController {
3838
layoutVideos(2)
3939

4040
// prepare resolution picker
41-
resolutionPicker.addItems(withTitles: Configs.Resolutions.map({ (res:Resolution) -> String in
42-
return res.name()
43-
}))
41+
resolutionPicker.addItems(withTitles: Configs.Resolutions.map { $0.name() })
4442
resolutionPicker.selectItem(at: GlobalSettings.shared.resolutionSetting.selectedOption().value)
4543

4644
// prepare fps picker
47-
fpsPicker.addItems(withTitles: Configs.Fps.map({ (fps:Int) -> String in
48-
return "\(fps)fps"
49-
}))
45+
fpsPicker.addItems(withTitles: Configs.Fps.map { "\($0)fps" })
5046
fpsPicker.selectItem(at: GlobalSettings.shared.fpsSetting.selectedOption().value)
5147

5248
// set up agora instance when view loaded

macOS/APIExample/Examples/Advanced/CustomVideoSourceMediaIO/CustomVideoSourceMediaIO.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,11 @@ class CustomVideoSourceMediaIO: BaseViewController {
3838
layoutVideos(2)
3939

4040
// prepare resolution picker
41-
resolutionPicker.addItems(withTitles: Configs.Resolutions.map({ (res:Resolution) -> String in
42-
return res.name()
43-
}))
41+
resolutionPicker.addItems(withTitles: Configs.Resolutions.map { $0.name() })
4442
resolutionPicker.selectItem(at: GlobalSettings.shared.resolutionSetting.selectedOption().value)
4543

4644
// prepare fps picker
47-
fpsPicker.addItems(withTitles: Configs.Fps.map({ (fps:Int) -> String in
48-
return "\(fps)fps"
49-
}))
45+
fpsPicker.addItems(withTitles: Configs.Fps.map { "\($0)fps" })
5046
fpsPicker.selectItem(at: GlobalSettings.shared.fpsSetting.selectedOption().value)
5147

5248
// set up agora instance when view loaded

macOS/APIExample/Examples/Advanced/CustomVideoSourcePush/CustomVideoSourcePush.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,11 @@ class CustomVideoSourcePush: BaseViewController {
4040
layoutVideos(2)
4141

4242
// prepare resolution picker
43-
resolutionPicker.addItems(withTitles: Configs.Resolutions.map({ (res:Resolution) -> String in
44-
return res.name()
45-
}))
43+
resolutionPicker.addItems(withTitles: Configs.Resolutions.map { $0.name() })
4644
resolutionPicker.selectItem(at: GlobalSettings.shared.resolutionSetting.selectedOption().value)
4745

4846
// prepare fps picker
49-
fpsPicker.addItems(withTitles: Configs.Fps.map({ (fps:Int) -> String in
50-
return "\(fps)fps"
51-
}))
47+
fpsPicker.addItems(withTitles: Configs.Fps.map { "\($0)fps" })
5248
fpsPicker.selectItem(at: GlobalSettings.shared.fpsSetting.selectedOption().value)
5349

5450
// set up agora instance when view loaded

macOS/APIExample/Examples/Advanced/RawMediaData/RawMediaData.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,11 @@ class RawMediaData: BaseViewController {
3737
layoutVideos(2)
3838

3939
// prepare resolution picker
40-
resolutionPicker.addItems(withTitles: Configs.Resolutions.map({ (res:Resolution) -> String in
41-
return res.name()
42-
}))
40+
resolutionPicker.addItems(withTitles: Configs.Resolutions.map { $0.name() })
4341
resolutionPicker.selectItem(at: GlobalSettings.shared.resolutionSetting.selectedOption().value)
4442

4543
// prepare fps picker
46-
fpsPicker.addItems(withTitles: Configs.Fps.map({ (fps:Int) -> String in
47-
return "\(fps)fps"
48-
}))
44+
fpsPicker.addItems(withTitles: Configs.Fps.map { "\($0)fps" })
4945
fpsPicker.selectItem(at: GlobalSettings.shared.fpsSetting.selectedOption().value)
5046

5147
// set up agora instance when view loaded

macOS/APIExample/Examples/Advanced/ScreenShare/ScreenShare.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,11 @@ class ScreenShare: BaseViewController {
7070
layoutVideos(2)
7171

7272
// prepare resolution picker
73-
resolutionPicker.addItems(withTitles: Configs.Resolutions.map({ (res:Resolution) -> String in
74-
return res.name()
75-
}))
73+
resolutionPicker.addItems(withTitles: Configs.Resolutions.map { $0.name() })
7674
resolutionPicker.selectItem(at: GlobalSettings.shared.resolutionSetting.selectedOption().value)
7775

7876
// prepare fps picker
79-
fpsPicker.addItems(withTitles: Configs.Fps.map({ (fps:Int) -> String in
80-
return "\(fps)fps"
81-
}))
77+
fpsPicker.addItems(withTitles: Configs.Fps.map { "\($0)fps" })
8278
fpsPicker.selectItem(at: GlobalSettings.shared.fpsSetting.selectedOption().value)
8379

8480
// prepare window manager and list

macOS/APIExample/Examples/Advanced/StreamEncryption/StreamEncryption.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,11 @@ class StreamEncryption: BaseViewController {
4040
layoutVideos(2)
4141

4242
// prepare resolution picker
43-
resolutionPicker.addItems(withTitles: Configs.Resolutions.map({ (res:Resolution) -> String in
44-
return res.name()
45-
}))
43+
resolutionPicker.addItems(withTitles: Configs.Resolutions.map { $0.name() })
4644
resolutionPicker.selectItem(at: GlobalSettings.shared.resolutionSetting.selectedOption().value)
4745

4846
// prepare fps picker
49-
fpsPicker.addItems(withTitles: Configs.Fps.map({ (fps:Int) -> String in
50-
return "\(fps)fps"
51-
}))
47+
fpsPicker.addItems(withTitles: Configs.Fps.map { "\($0)fps" })
5248
fpsPicker.selectItem(at: GlobalSettings.shared.fpsSetting.selectedOption().value)
5349

5450
// prepare encryptionn picker

macOS/APIExample/Examples/Basic/JoinChannelVideo/JoinChannelVideo.swift

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,11 @@ class JoinChannelVideoMain: BaseViewController {
5757
layoutVideos(2)
5858

5959
// prepare resolution picker
60-
resolutionPicker.addItems(withTitles: Configs.Resolutions.map({ (res:Resolution) -> String in
61-
return res.name()
62-
}))
60+
resolutionPicker.addItems(withTitles: Configs.Resolutions.map { $0.name() })
6361
resolutionPicker.selectItem(at: GlobalSettings.shared.resolutionSetting.selectedOption().value)
6462

6563
// prepare fps picker
66-
fpsPicker.addItems(withTitles: Configs.Fps.map({ (fps:Int) -> String in
67-
return "\(fps)fps"
68-
}))
64+
fpsPicker.addItems(withTitles: Configs.Fps.map { "\($0)fps" })
6965
fpsPicker.selectItem(at: GlobalSettings.shared.fpsSetting.selectedOption().value)
7066
rolePicker.addItems(withTitles: AgoraClientRole.allValues().map({$0.description()}))
7167

0 commit comments

Comments
 (0)