Improve test reliability

Author: J Burnett

test/IntListRandomizerTests.cs

@@ -14,6 +14,7 @@ public class IntListRandomizerTests : IClassFixture<IntListTestFixture>
 	{
 		IntListTestFixture _testData;
 
+
 		public IntListRandomizerTests(IntListTestFixture testData)
 		{
 			_testData = testData;
@@ -25,14 +26,10 @@ public IntListRandomizerTests(IntListTestFixture testData)
 		[Fact]
 		public void random_element_from_int_list()
 		{
-			// Get random elements from ~1/10 of the list.  The probability of sequential duplicates
-			//	increases when covering more of the available elements.
-			int prev = -1;
-			for (int i = 0; i < _testData.TestList.Count/10; ++i)
+			for (int i = 0; i < _testData.TestList.Count; ++i)
 			{
 				int curr = _testData.TestList.Random();
-				curr.Should().NotBe(prev);
-				prev = curr;
+				curr.Should().BeGreaterOrEqualTo(IntListTestFixture.MinTestValue);
 			}
 		}
 
@@ -44,7 +41,7 @@ public void random_element_from_int_list_by_IEnumerable()
 			foreach (var itr in enumr)
 			{
 				int curr = enumr.Random();
-				curr.Should().BeGreaterThan(-1);
+				curr.Should().BeGreaterOrEqualTo(IntListTestFixture.MinTestValue);
 			}
 		}
 
@@ -73,12 +70,11 @@ public void random_element_from_()
 
 			// Get random elements from ~1/10 of the list.  The probability of sequential duplicates
 			//	increases when covering more of the available elements.
-			KeyValuePair<int, string> prev = new KeyValuePair<int, string>();
-			for (int i = 0; i < list.Count/10; ++i)
+			for (int i = 0; i < list.Count; ++i)
 			{
 				var curr = list.Random();
-				curr.Should().NotBe(prev);
-				prev = curr;
+				curr.Key.Should().BeGreaterOrEqualTo(IntListTestFixture.MinTestValue);
+				curr.Value.Should().BeEquivalentTo(curr.Key.ToString());
 			}
 		}
 

test/IntListTestFixture.cs

@@ -10,15 +10,17 @@ public class IntListTestFixture : IDisposable
     {
 
         public List<int> TestList { get; set; }
+        public const int MinTestValue = 0;
+        public const int MaxTestValue = 250;
+
 
         public IntListTestFixture()
         {
 			TestList = new List<int>();
-			for (int i = 0; i < 250; ++i)
+			for (int i = MinTestValue; i < MaxTestValue; ++i)
             {
                 TestList.Add(i);
             }
-
         }