Additional tests

HTTP test and unit test

Author: namedgraph

http-tests/proxy/GET-proxied-external-xhtml-406.sh

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+initialize_dataset "$END_USER_BASE_URL" "$TMP_END_USER_DATASET" "$END_USER_ENDPOINT_URL"
+initialize_dataset "$ADMIN_BASE_URL" "$TMP_ADMIN_DATASET" "$ADMIN_ENDPOINT_URL"
+purge_cache "$END_USER_VARNISH_SERVICE"
+purge_cache "$ADMIN_VARNISH_SERVICE"
+purge_cache "$FRONTEND_VARNISH_SERVICE"
+
+# add agent to the readers group to be able to read documents
+
+add-agent-to-group.sh \
+  -f "$OWNER_CERT_FILE" \
+  -p "$OWNER_CERT_PWD" \
+  --agent "$AGENT_URI" \
+  "${ADMIN_BASE_URL}acl/groups/readers/"
+
+# check for Not Acceptable exception when requesting (X)HTML for a proxied external URL
+
+curl -k -w "%{http_code}\n" -o /dev/null -s \
+  -G \
+  -H "Accept: text/html" \
+  -E "$AGENT_CERT_FILE":"$AGENT_CERT_PWD" \
+  --data-urlencode "uri=http://f1d2d4cf-90bb-4f5b-ae4b-921e584b6edd.org" \
+  "$END_USER_BASE_URL" \
+| grep -q "$STATUS_NOT_ACCEPTABLE"

src/test/java/com/atomgraph/linkeddatahub/server/filter/request/ProxyRequestFilterTest.java

@@ -0,0 +1,105 @@
+/**
+ *  Copyright 2025 Martynas Jusevičius <martynas@atomgraph.com>
+ *
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ *
+ */
+package com.atomgraph.linkeddatahub.server.filter.request;
+
+import com.atomgraph.client.MediaTypes;
+import com.atomgraph.client.vocabulary.AC;
+import jakarta.ws.rs.NotAcceptableException;
+import jakarta.ws.rs.container.ContainerRequestContext;
+import jakarta.ws.rs.core.MediaType;
+import jakarta.ws.rs.core.Request;
+import jakarta.ws.rs.core.Variant;
+import java.io.IOException;
+import java.net.URI;
+import java.util.Collections;
+import java.util.Locale;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.junit.MockitoJUnitRunner;
+import static org.mockito.ArgumentMatchers.anyList;
+import static org.mockito.Mockito.*;
+
+/**
+ * Unit tests for {@link ProxyRequestFilter}.
+ *
+ * @author Martynas Jusevičius {@literal <martynas@atomgraph.com>}
+ */
+@RunWith(MockitoJUnitRunner.class)
+public class ProxyRequestFilterTest
+{
+
+    @Mock private ContainerRequestContext requestContext;
+    @Mock private Request request;
+    @Mock private com.atomgraph.linkeddatahub.Application system;
+
+    private ProxyRequestFilter filter;
+
+    @Before
+    public void setUp()
+    {
+        filter = new ProxyRequestFilter();
+        filter.mediaTypes = new MediaTypes();
+        filter.request = request;
+        filter.system = system;
+        when(system.getSupportedLanguages()).thenReturn(Collections.emptyList());
+    }
+
+    /** No proxy properties set — filter must be a no-op. */
+    @Test
+    public void testNonProxyRequestSkipsFilter() throws IOException
+    {
+        // getProperty returns null by default; resolveTargetURI returns empty → filter exits immediately
+        filter.filter(requestContext);
+        verify(request, never()).selectVariant(anyList());
+        verify(requestContext, never()).abortWith(any());
+    }
+
+    /** No acceptable RDF/SPARQL variant — filter must throw 406. */
+    @Test(expected = NotAcceptableException.class)
+    public void testNullVariantThrowsNotAcceptable() throws IOException
+    {
+        when(requestContext.getProperty(AC.uri.getURI()))
+            .thenReturn(URI.create("http://example.org/resource"));
+        when(request.selectVariant(anyList())).thenReturn(null);
+        filter.filter(requestContext);
+    }
+
+    /** text/html selected as best variant — filter must throw 406. */
+    @Test(expected = NotAcceptableException.class)
+    public void testHtmlVariantThrowsNotAcceptable() throws IOException
+    {
+        when(requestContext.getProperty(AC.uri.getURI()))
+            .thenReturn(URI.create("http://example.org/resource"));
+        when(request.selectVariant(anyList()))
+            .thenReturn(new Variant(MediaType.TEXT_HTML_TYPE, (Locale) null, null));
+        filter.filter(requestContext);
+    }
+
+    /** application/xhtml+xml selected as best variant — filter must throw 406. */
+    @Test(expected = NotAcceptableException.class)
+    public void testXhtmlVariantThrowsNotAcceptable() throws IOException
+    {
+        when(requestContext.getProperty(AC.uri.getURI()))
+            .thenReturn(URI.create("http://example.org/resource"));
+        when(request.selectVariant(anyList()))
+            .thenReturn(new Variant(MediaType.APPLICATION_XHTML_XML_TYPE, (Locale) null, null));
+        filter.filter(requestContext);
+    }
+
+}