remove deprecated features

Author: garak

src/Bowerphp/Command/Helper/DialogHelper.php

@@ -11,13 +11,13 @@
 
 namespace Bowerphp\Command\Helper;
 
-use Symfony\Component\Console\Helper\QuestionHelper as BaseDialogHelper;
+use Symfony\Component\Console\Helper\QuestionHelper as BaseQuestionHelper;
 use Symfony\Component\Console\Question\Question;
 
 /**
  * Copied by Composer https://github.com/composer/composer
  */
-class QuestionHelper extends BaseDialogHelper
+class QuestionHelper extends BaseQuestionHelper
 {
     /**
      * Build text for asking a question. For example:

src/Bowerphp/Command/Helper/QuestionHelper.php

@@ -50,29 +50,15 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         // @codeCoverageIgnoreStart
         if ($input->isInteractive()) {
-            if (class_exists('Symfony\Component\Console\Helper\DialogHelper')) {
-                $dialog = $this->getHelperSet()->get('dialog');
-                $params['name'] = $dialog->ask(
-                    $output,
-                    $dialog->getQuestion('Please specify a name for project', $params['name']),
-                    $params['name']
-                );
-                $params['author'] = $dialog->ask(
-                    $output,
-                    $dialog->getQuestion('Please specify an author', $params['author']),
-                    $params['author']
-                );
-            } else {
-                $dialog = $this->getHelperSet()->get('question');
+            $dialog = $this->getHelperSet()->get('question');
 
-                $params['name'] = $dialog->ask(
-                    $input, $output, $dialog->getQuestion('Please specify a name for project', $params['name'])
-                );
+            $params['name'] = $dialog->ask(
+                $input, $output, $dialog->getQuestion('Please specify a name for project', $params['name'])
+            );
 
-                $params['author'] = $dialog->ask(
-                    $input, $output, $dialog->getQuestion('Please specify an author', $params['author'])
-                );
-            }
+            $params['author'] = $dialog->ask(
+                $input, $output, $dialog->getQuestion('Please specify an author', $params['author'])
+            );
         }
         // @codeCoverageIgnoreEnd
         $bowerphp = $this->getBowerphp($output);

src/Bowerphp/Command/InitCommand.php

@@ -120,11 +120,7 @@ protected function getDefaultInputDefinition()
     protected function getDefaultHelperSet()
     {
         $helperSet = parent::getDefaultHelperSet();
-        if (class_exists('Symfony\Component\Console\Helper\DialogHelper')) {
-            $helperSet->set(new \Bowerphp\Command\Helper\DialogHelper());
-        } else {
-            $helperSet->set(new \Bowerphp\Command\Helper\QuestionHelper());
-        }
+        $helperSet->set(new \Bowerphp\Command\Helper\QuestionHelper());
 
         return $helperSet;
     }

src/Bowerphp/Console/Application.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace Bowerphp\Test\Command\Helper;
+
+class QuestionHelperTest extends \PHPUnit_Framework_TestCase
+{
+    public function testGetQuestion()
+    {
+        $helper = new \Bowerphp\Command\Helper\QuestionHelper();
+        $this->assertEquals('<info>This is a question</info> [<comment>default reply</comment>]: ', $helper->getQuestion('This is a question', 'default reply')->getQuestion());
+        $this->assertEquals('<info>Another question</info>- ', $helper->getQuestion('Another question', null, '-')->getQuestion());
+    }
+}