Merge pull request #3198 from BrentOzarULTD/dev

2022-12-13 Release

Author: BrentOzar

Install-All-Scripts.sql

@@ -43,10 +43,9 @@ To install, [download the latest release ZIP](https://github.com/BrentOzarULTD/S
 
 The First Responder Kit runs on:
 
-* SQL Server 2012, 2014, 2016, 2017, 2019 on Windows - fully supported.
-* SQL Server 2017, 2019 on Linux - yes, fully supported except sp_AllNightLog and sp_DatabaseRestore, which require xp_cmdshell, which Microsoft doesn't provide on Linux.
-* SQL Server 2008, 2008R2 - not officially supported since it's out of Microsoft support, but we try not to make changes that would break functionality here.
-* SQL Server 2000, 2005 - not supported at all.
+* SQL Server 2012, 2014, 2016, 2017, 2019, 2022 on Windows - fully supported.
+* SQL Server on Linux - yes, fully supported except sp_AllNightLog and sp_DatabaseRestore, which require xp_cmdshell, which Microsoft doesn't provide on Linux.
+* SQL Server 2008 R2 and earlier - not supported since it's out of Microsoft support, but check the Deprecated folder for older versions of the scripts which may work, depending on your versions and compatibility levels.
 * Amazon RDS SQL Server - fully supported.
 * Azure SQL DB - not supported. Some of the procedures work, but some don't, and Microsoft has a tendency to change DMVs in Azure without warning, so we don't put any effort into supporting it. If it works, great! If not, any changes to make it work would be on you. [See the contributing.md file](CONTRIBUTING.md) for how to do that.
 

Install-Core-Blitz-No-Query-Store.sql

@@ -41,7 +41,7 @@ DELETE FROM dbo.SqlServerVersions;
 INSERT INTO dbo.SqlServerVersions
     (MajorVersionNumber, MinorVersionNumber, Branch, [Url], ReleaseDate, MainstreamSupportEndDate, ExtendedSupportEndDate, MajorVersionName, MinorVersionName)
 VALUES
-    (16, 600, 'CTP2', 'https://support.microsoft.com/en-us/help/5011644', '2022-05-24', '2022-05-24', '2022-05-24', 'SQL Server 2022', 'CTP 2.0'),
+    (16, 1000, 'RTM', '', '2022-11-15', '2028-01-11', '2033-01-11', 'SQL Server 2022', 'RTM'),
     (15, 4261, 'CU18', 'https://support.microsoft.com/en-us/help/5017593', '2022-09-28', '2025-01-07', '2030-01-08', 'SQL Server 2019', 'Cumulative Update 18'),
     (15, 4249, 'CU17', 'https://support.microsoft.com/en-us/help/5016394', '2022-08-11', '2025-01-07', '2030-01-08', 'SQL Server 2019', 'Cumulative Update 17'),
     (15, 4236, 'CU16 GDR', 'https://support.microsoft.com/en-us/help/5014353', '2022-06-14', '2025-01-07', '2030-01-08', 'SQL Server 2019', 'Cumulative Update 16 GDR'),

Install-Core-Blitz-With-Query-Store.sql

@@ -31,7 +31,7 @@ SET STATISTICS XML OFF;
 BEGIN;
 
 
-SELECT @Version = '8.11', @VersionDate = '20221013';
+SELECT @Version = '8.12', @VersionDate = '20221213';
 
 IF(@VersionCheckMode = 1)
 BEGIN
@@ -1186,22 +1186,31 @@ IF @Restore = 1
 																	ELSE 0
 																END
 										FROM msdb.dbo.restore_worker rw WITH (UPDLOCK, HOLDLOCK, ROWLOCK)
-										WHERE 
-											  (		/*This section works on databases already part of the backup cycle*/
-												    rw.is_started = 0
-												AND rw.is_completed = 1
-												AND rw.last_log_restore_start_time < DATEADD(SECOND, (@rto * -1), GETDATE()) 
-                                                AND (rw.error_number IS NULL OR rw.error_number > 0) /* negative numbers indicate human attention required */
-											  )
-										OR    
-											  (		/*This section picks up newly added databases by DiskPollster*/
-											  	    rw.is_started = 0
-											  	AND rw.is_completed = 0
-											  	AND rw.last_log_restore_start_time = '1900-01-01 00:00:00.000'
-											  	AND rw.last_log_restore_finish_time = '9999-12-31 00:00:00.000'
-                                                AND (rw.error_number IS NULL OR rw.error_number > 0) /* negative numbers indicate human attention required */
-											  )
-										AND rw.ignore_database = 0
+										WHERE (
+													(		/*This section works on databases already part of the backup cycle*/
+															rw.is_started = 0
+														AND rw.is_completed = 1
+														AND rw.last_log_restore_start_time < DATEADD(SECOND, (@rto * -1), GETDATE()) 
+														AND (rw.error_number IS NULL OR rw.error_number > 0) /* negative numbers indicate human attention required */
+													)
+												OR    
+													(		/*This section picks up newly added databases by DiskPollster*/
+															rw.is_started = 0
+														AND rw.is_completed = 0
+														AND rw.last_log_restore_start_time = '1900-01-01 00:00:00.000'
+														AND rw.last_log_restore_finish_time = '9999-12-31 00:00:00.000'
+														AND (rw.error_number IS NULL OR rw.error_number > 0) /* negative numbers indicate human attention required */
+													)
+											)
+										AND rw.ignore_database = 0										
+										AND NOT EXISTS	(
+															/* Validation check to ensure the database either doesn't exist or is in a restoring/standby state */
+															SELECT 1 
+															FROM sys.databases d
+															WHERE d.name = rw.database_name
+															AND state <> 1 /* Restoring */
+															AND NOT (state=0 AND d.is_in_standby=1) /* standby mode */
+														)
 										ORDER BY rw.last_log_restore_start_time ASC, rw.last_log_restore_finish_time ASC, rw.database_name ASC;
 
 

README.md

@@ -38,7 +38,7 @@ SET STATISTICS XML OFF;
 
 BEGIN;
 
-SELECT @Version = '8.11', @VersionDate = '20221013';
+SELECT @Version = '8.12', @VersionDate = '20221213';
 
 IF(@VersionCheckMode = 1)
 BEGIN

SqlServerVersions.sql

@@ -38,7 +38,7 @@ AS
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
 
-	SELECT @Version = '8.11', @VersionDate = '20221013';
+	SELECT @Version = '8.12', @VersionDate = '20221213';
 	SET @OutputType = UPPER(@OutputType);
 
     IF(@VersionCheckMode = 1)
@@ -1090,7 +1090,7 @@ AS
 												)
 												OR
 												(
-													Convert(datetime,ll.Value) < DATEADD(dd,-7, GETDATE())
+													Convert(datetime,ll.Value,21) < DATEADD(dd,-7, GETDATE())
 												)
 
 											);

sp_AllNightLog.sql

@@ -37,7 +37,7 @@ AS
 SET NOCOUNT ON;
 SET STATISTICS XML OFF;
 
-SELECT @Version = '8.11', @VersionDate = '20221013';
+SELECT @Version = '8.12', @VersionDate = '20221213';
 
 IF(@VersionCheckMode = 1)
 BEGIN

sp_AllNightLog_Setup.sql

@@ -24,7 +24,7 @@ AS
 	SET STATISTICS XML OFF;
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-	SELECT @Version = '8.11', @VersionDate = '20221013';
+	SELECT @Version = '8.12', @VersionDate = '20221213';
 
 	IF(@VersionCheckMode = 1)
 	BEGIN