Merge pull request #3358 from Montro1981/SQL-Server-First-Responder-Kit_3355

#3355 Added permissions check for MSDB

Author: BrentOzar

sp_Blitz.sql

@@ -336,6 +336,35 @@ AS
             	    SET @SkipModel = 1; /*We don't have read permissions in the model database*/
             	END;
 			END;
+
+			IF ISNULL(@SkipMSDB, 0) != 1 /*If @SkipMSDB hasn't been set to 1 by the caller*/
+			BEGIN
+				IF EXISTS
+				(
+					SELECT	1/0
+            	    FROM	@db_perms
+            	    WHERE	database_name = N'msdb'
+				)
+				BEGIN
+					BEGIN TRY
+						IF EXISTS
+						(
+            	            SELECT	1/0
+            	            FROM	msdb.sys.objects
+						)
+						BEGIN
+							SET @SkipMSDB = 0; /*We have read permissions in the msdb database, and can view the objects*/
+						END;
+					END TRY
+					BEGIN CATCH
+						SET @SkipMSDB = 1; /*We have read permissions in the msdb database ... oh wait we got tricked, we can't view the objects*/
+					END CATCH;
+				END;
+				ELSE
+				BEGIN
+					SET @SkipMSDB = 1; /*We don't have read permissions in the msdb database*/
+				END;
+			END;
 		END;
 
 		SET @crlf = NCHAR(13) + NCHAR(10);
@@ -502,6 +531,21 @@ AS
         FROM (VALUES(NULL, 29, NULL)) AS v (DatabaseName, CheckID, ServerName) /*Looks for user tables in model*/
         WHERE @SkipModel = 1;
 
+		INSERT #SkipChecks (DatabaseName, CheckID, ServerName)
+		SELECT
+			v.*
+		FROM (VALUES(NULL,   6, NULL), /*Jobs Owned By Users*/
+					(NULL,  28, NULL), /*SQL Agent Job Runs at Startup*/
+					(NULL,  57, NULL), /*Tables in the MSDB Database*/
+					(NULL,  79, NULL), /*Shrink Database Job*/
+					(NULL,  94, NULL), /*Agent Jobs Without Failure Emails*/
+					(NULL, 123, NULL), /*Agent Jobs Starting Simultaneously*/
+					(NULL, 180, NULL), /*Shrink Database Step In Maintenance Plan*/
+					(NULL, 181, NULL), /*Repetitive Maintenance Tasks*/
+					(NULL, 219, NULL)  /*Alerts Without Event Descriptions*/
+			) AS v (DatabaseName, CheckID, ServerName) 
+		WHERE @SkipMSDB = 1;
+
 		INSERT #SkipChecks (DatabaseName, CheckID, ServerName)
 		SELECT
 		    v.*