fix: Swaps getUsersGroupsOnSp and getUsersGroupsOnFacility methods

Author: BaranekD

lib/Adapter.php

@@ -178,15 +178,15 @@ abstract public function getFacilityByClientId($clientId, $clientIdAttr);
      *
      * @return Group[] from vo which are assigned to all facilities with spEntityId for this userId
      */
-    abstract public function getUsersGroupsOnSp($spEntityId, $userId);
+    abstract public function getUsersGroupsOnFacility($spEntityId, $userId);
 
     /**
      * @param Facility $facility entity id of the sp
      * @param int      $userId
      *
      * @return Group[] from vo which are assigned to all facilities with spEntityId for this userId
      */
-    abstract public function getUsersGroupsOnFacility($facility, $userId);
+    abstract public function getUsersGroupsOnSp($facility, $userId);
 
     /**
      * @param <String, String> map $attribute

lib/AdapterLdap.php

@@ -461,14 +461,14 @@ public function setUserExtSourceAttributes($userExtSourceId, $attributes)
         $this->fallbackAdapter->setUserExtSourceAttributes($userExtSourceId, $attributes);
     }
 
-    public function getUsersGroupsOnSp($spEntityId, $userId)
+    public function getUsersGroupsOnFacility($spEntityId, $userId)
     {
         $facility = $this->getFacilityByEntityId($spEntityId);
 
-        return self::getUsersGroupsOnFacility($facility, $userId);
+        return self::getUsersGroupsOnSp($facility, $userId);
     }
 
-    public function getUsersGroupsOnFacility($facility, $userId)
+    public function getUsersGroupsOnSp($facility, $userId)
     {
         if (null === $facility) {
             return [];

lib/AdapterRpc.php

@@ -380,14 +380,14 @@ public function getFacilityAttribute($facility, $attrName)
         return $perunAttr['value'];
     }
 
-    public function getUsersGroupsOnSp($spEntityId, $userId)
+    public function getUsersGroupsOnFacility($spEntityId, $userId)
     {
         $facility = $this->getFacilityByEntityId($spEntityId);
 
-        return self::getUsersGroupsOnFacility($facility, $userId);
+        return self::getUsersGroupsOnSp($facility, $userId);
     }
 
-    public function getUsersGroupsOnFacility($facility, $userId)
+    public function getUsersGroupsOnSp($facility, $userId)
     {
         if (null === $facility) {
             return [];

lib/Auth/Process/PerunIdentity.php

@@ -241,7 +241,7 @@ public function process(&$request)
 
             $this->checkMemberStateDefaultVo($request, $user, $uids);
 
-            $groups = $this->adapter->getUsersGroupsOnSp($this->spEntityId, $user->getId());
+            $groups = $this->adapter->getUsersGroupsOnFacility($this->spEntityId, $user->getId());
 
             if ($this->checkGroupMembership && empty($groups)) {
                 if ($this->allowRegistrationToGroups) {

lib/Auth/Process/PerunUserGroups.php

@@ -52,7 +52,7 @@ public function process(&$request)
             throw new Exception(self::DEBUG_PREFIX . 'Cannot find SP EntityID');
         }
 
-        $groups = $this->adapter->getUsersGroupsOnSp($spEntityId, $user->getId());
+        $groups = $this->adapter->getUsersGroupsOnFacility($spEntityId, $user->getId());
         $request[PerunConstants::PERUN][PerunConstants::USER_GROUPS] = $groups;
     }
 }

lib/Auth/Process/SpAuthorization.php

@@ -171,7 +171,7 @@ public function process(&$request)
             return;
         }
 
-        $userGroups = $this->adapter->getUsersGroupsOnFacility($facility, $user->getId());
+        $userGroups = $this->adapter->getUsersGroupsOnSp($facility, $user->getId());
         if (!empty($userGroups)) {
             Logger::info(self::DEBUG_PREFIX . 'User satisfies the group membership check.');
         } else {