Skip to content

Commit a56e940

Browse files
authored
update a test failing with new libarchive versions (#131)
fixes #130
1 parent 5f7008d commit a56e940

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

tests/test_entry.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
import pytest
1111

12-
from libarchive import memory_reader, memory_writer
12+
from libarchive import ArchiveError, memory_reader, memory_writer
1313
from libarchive.entry import ArchiveEntry, ConsumedArchiveEntry, PassedArchiveEntry
1414

1515
from . import data_dir, get_entries, get_tarinfos
@@ -64,7 +64,13 @@ def test_check_ArchiveEntry_against_TarInfo():
6464

6565

6666
def test_check_archiveentry_using_python_testtar():
67-
check_entries(join(data_dir, 'testtar.tar'))
67+
# This test behaves differently depending on the libarchive version:
68+
# 3.5, 3.6 and presumably all future versions reject the archive as damaged,
69+
# whereas older versions accepted it.
70+
try:
71+
check_entries(join(data_dir, 'testtar.tar'))
72+
except ArchiveError as e:
73+
assert e.msg == "Damaged tar archive"
6874

6975

7076
def test_check_archiveentry_with_unicode_and_binary_entries_tar():

0 commit comments

Comments
 (0)