fix: block now drops one item

Author: The-Code-Monkey

src/client/java/com/tcm/MineTale/datagen/ModLootTableProvider.java

@@ -1,20 +1,27 @@
 package com.tcm.MineTale.datagen;
 
+import com.tcm.MineTale.block.workbenches.AbstractWorkbench;
 import com.tcm.MineTale.registry.ModBlocks;
 import com.tcm.MineTale.registry.ModItems;
 import net.fabricmc.fabric.api.datagen.v1.FabricDataOutput;
 import net.fabricmc.fabric.api.datagen.v1.provider.FabricBlockLootTableProvider;
+import net.minecraft.advancements.criterion.StatePropertiesPredicate;
 import net.minecraft.core.HolderLookup;
 import net.minecraft.core.registries.Registries;
 import net.minecraft.world.item.Item;
 import net.minecraft.world.item.enchantment.Enchantment;
 import net.minecraft.world.item.enchantment.Enchantments;
 import net.minecraft.world.level.block.Block;
+import net.minecraft.world.level.block.state.properties.ChestType;
+import net.minecraft.world.level.block.state.properties.DoubleBlockHalf;
+import net.minecraft.world.level.storage.loot.LootPool;
 import net.minecraft.world.level.storage.loot.LootTable;
 import net.minecraft.world.level.storage.loot.entries.LootItem;
 import net.minecraft.world.level.storage.loot.entries.LootPoolSingletonContainer;
 import net.minecraft.world.level.storage.loot.functions.ApplyBonusCount;
 import net.minecraft.world.level.storage.loot.functions.SetItemCountFunction;
+import net.minecraft.world.level.storage.loot.predicates.ExplosionCondition;
+import net.minecraft.world.level.storage.loot.predicates.LootItemBlockStatePropertyCondition;
 import net.minecraft.world.level.storage.loot.providers.number.ConstantValue;
 import net.minecraft.world.level.storage.loot.providers.number.UniformGenerator;
 
@@ -30,11 +37,26 @@ public void generate() {
         ///Block Drops Itself
         //Bug!! Workbenches currently drop items based on the amount of blocks
         //the multiblock is. For example the Furnaces currently drop 4 furnaces.
-        dropSelf(ModBlocks.FURNACE_WORKBENCH_BLOCK_T1);
-        dropSelf(ModBlocks.FURNACE_WORKBENCH_BLOCK_T1);
+        // dropSelf(ModBlocks.FURNACE_WORKBENCH_BLOCK_T1);
+        // dropSelf(ModBlocks.FURNACE_WORKBENCH_BLOCK_T1);
         dropSelf(ModBlocks.ARMORERS_WORKBENCH_BLOCK);
         dropSelf(ModBlocks.CAMPFIRE_WORKBENCH_BLOCK);
         dropSelf(ModBlocks.WORKBENCH_WORKBENCH_BLOCK);
+
+        this.add(ModBlocks.FURNACE_WORKBENCH_BLOCK_T1, 
+            LootTable.lootTable() // Use the static factory method to start the builder
+                .withPool(LootPool.lootPool()
+                    .setRolls(ConstantValue.exactly(1.0F))
+                    .add(LootItem.lootTableItem(ModBlocks.FURNACE_WORKBENCH_BLOCK_T1))
+                    .when(LootItemBlockStatePropertyCondition.hasBlockStateProperties(ModBlocks.FURNACE_WORKBENCH_BLOCK_T1)
+                        .setProperties(StatePropertiesPredicate.Builder.properties()
+                            .hasProperty(AbstractWorkbench.HALF, DoubleBlockHalf.LOWER)
+                            .hasProperty(AbstractWorkbench.TYPE, ChestType.LEFT)
+                        )
+                    )
+                    .when(ExplosionCondition.survivesExplosion())
+                )
+        );
     }
 
 

src/main/java/com/tcm/MineTale/block/workbenches/AbstractWorkbench.java

@@ -23,6 +23,7 @@
 import net.minecraft.world.level.block.state.BlockState;
 import net.minecraft.world.level.block.state.StateDefinition;
 import net.minecraft.world.level.block.state.properties.*;
+import net.minecraft.world.level.gameevent.GameEvent;
 import net.minecraft.world.phys.BlockHitResult;
 import net.minecraft.world.phys.shapes.Shapes;
 import net.minecraft.world.phys.shapes.VoxelShape;
@@ -33,6 +34,8 @@
 
 import java.util.function.Supplier;
 
+// DoorBlock
+
 public abstract class AbstractWorkbench<E extends AbstractWorkbenchEntity> extends BaseEntityBlock {
     public static final EnumProperty<Direction> FACING = HorizontalDirectionalBlock.FACING;
     public static final EnumProperty<DoubleBlockHalf> HALF = BlockStateProperties.DOUBLE_BLOCK_HALF;
@@ -351,4 +354,52 @@ protected float getShadeBrightness(BlockState state, BlockGetter level, BlockPos
         // We want 1.0F to ensure the block doesn't cast a pitch-black shadow on itself.
         return 1.0F;
     }
+
+    @Override
+    public BlockState playerWillDestroy(Level level, BlockPos pos, BlockState state, Player player) {
+        if (!level.isClientSide()) {
+            BlockPos masterPos = getMasterPos(state, pos);
+            boolean isMaster = pos.equals(masterPos);
+
+            // Iterate through the entire 2x2 or 1x2 structure
+            for (int y = 0; y <= (isTall ? 1 : 0); y++) {
+                for (int x = 0; x <= (isWide ? 1 : 0); x++) {
+                    Direction facing = state.getValue(FACING);
+                    BlockPos targetPos = masterPos.above(y).relative(facing.getClockWise(), x);
+
+                    // Skip the block the player is currently mining
+                    if (targetPos.equals(pos)) continue;
+
+                    BlockState targetState = level.getBlockState(targetPos);
+                    if (targetState.is(this) && getMasterPos(targetState, targetPos).equals(masterPos)) {
+                        if (isMaster) {
+                            // If we are mining the Master, destroy others SILENTLY
+                            level.setBlock(targetPos, Blocks.AIR.defaultBlockState(), 35);
+                        } else {
+                            // If we are mining a Slave block, we need to handle the Master carefully.
+                            // If the Master is at this targetPos, destroy it WITH drops.
+                            if (targetPos.equals(masterPos)) {
+                                level.destroyBlock(targetPos, !player.isCreative());
+                            } else {
+                                // Otherwise, it's just another slave block, remove silently.
+                                level.setBlock(targetPos, Blocks.AIR.defaultBlockState(), 35);
+                            }
+                        }
+                        level.gameEvent(GameEvent.BLOCK_DESTROY, targetPos, GameEvent.Context.of(player, targetState));
+                    }
+                }
+            }
+
+            // Final tweak: If the player is mining a SLAVE block, 
+            // we must prevent the slave block itself from dropping.
+            if (!isMaster && !player.isCreative()) {
+                // This prevents the current block from dropping its loot table 
+                // because we already triggered the Master's drop above.
+                state = state.setValue(BlockStateProperties.LIT, false); // Optional: change state to desync loot
+                level.setBlock(pos, Blocks.AIR.defaultBlockState(), 35);
+            }
+        }
+
+        return super.playerWillDestroy(level, pos, state, player);
+    }
 }