Skip to content

Commit a962874

Browse files
matejakjan-cerny
andauthored
Apply suggestions from code review
Co-authored-by: Jan Černý <jcerny@redhat.com>
1 parent a0be5af commit a962874

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

_posts/2023-04-21-mrac.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ However, in order to be able to come with workflows that introduce an added valu
4141
Our team has come up with these ideas so far:
4242

4343
- Lower the pressure on rules - enable coverage of a security requirement by more than one rule.
44-
- Be able to split a rule into such a set of rules easily.
44+
- Be able to split a rule into a set of rules easily.
4545
- Enhance the declarative aspect of the project.
4646
- Introduce a component-centric view to the project.
4747
- Facilitate extension of a rule's scope.
@@ -89,7 +89,7 @@ Profiles then can be [defined](https://github.com/ComplianceAsCode/content/blob/
8989
As an additional benefit, the assignment of rules to security controls can be reused by other parts of the project.
9090

9191
However, this declarative concept can be extended beyond profile compositions.
92-
We often use constructs s.a. `{{% if product in ("rhel8", "rhel9") %}}` instead of a more generic and understandable `{{% if product.prefers_single_file_sshd_configuration %}}` or something analogous.
92+
We often use constructs s.a. `{{% if product in ("rhel8", "rhel9") %}}` instead of a more generic and understandable `{{% if product.prefers_single_file_sshd_configuration %}}` or similar.
9393

9494
In other words, we shouldn't miss an opportunity to declare that a certain product has a particular property, and every other part of the content should refer to those properties rather than to product names.
9595
Designing such product properties in a way that is smart, doesn't get in the way and that can be reused in prose, checks and remediations is not trivial.

0 commit comments

Comments
 (0)