Reduce comparisons (#2148)

lifenjoiner · web-flow · commit 568f54fabbd1 · 2022-07-08T14:11:51.000+02:00
diff --git a/dnscrypt-proxy/crypto.go b/dnscrypt-proxy/crypto.go
@@ -106,10 +106,9 @@ func (proxy *Proxy) Encrypt(
 		minQuestionSize += int(xpad[0])
 	}
 	paddedLength := Min(MaxDNSUDPPacketSize, (Max(minQuestionSize, QueryOverhead)+1+63) & ^63)
-	if proto == "udp" && serverInfo.knownBugs.fragmentsBlocked {
+	if serverInfo.knownBugs.fragmentsBlocked && proto == "udp" {
 		paddedLength = MaxDNSUDPSafePacketSize
-	}
-	if serverInfo.Relay != nil && proto == "tcp" {
+	} else if serverInfo.Relay != nil && proto == "tcp" {
 		paddedLength = MaxDNSPacketSize
 	}
 	if QueryOverhead+len(packet)+1 > paddedLength {

Original file line number	Diff line number	Diff line change
`@@ -106,10 +106,9 @@ func (proxy *Proxy) Encrypt(`
`106`	`106`	`minQuestionSize += int(xpad[0])`
`107`	`107`	`}`
`108`	`108`	`paddedLength := Min(MaxDNSUDPPacketSize, (Max(minQuestionSize, QueryOverhead)+1+63) & ^63)`
`109`		`- if proto == "udp" && serverInfo.knownBugs.fragmentsBlocked {`
	`109`	`+ if serverInfo.knownBugs.fragmentsBlocked && proto == "udp" {`
`110`	`110`	`paddedLength = MaxDNSUDPSafePacketSize`
`111`		`- }`
`112`		`- if serverInfo.Relay != nil && proto == "tcp" {`
	`111`	`+ } else if serverInfo.Relay != nil && proto == "tcp" {`
`113`	`112`	`paddedLength = MaxDNSPacketSize`
`114`	`113`	`}`
`115`	`114`	`if QueryOverhead+len(packet)+1 > paddedLength {`