Raise error for invalid relay (#2128)

lifenjoiner · web-flow · commit 72a602577a1d · 2022-06-15T13:16:06.000+02:00
* Raise error for invalid relay

* Keep error messages the same

* Distinguish this from validation failed
diff --git a/dnscrypt-proxy/serversInfo.go b/dnscrypt-proxy/serversInfo.go
@@ -467,8 +467,9 @@ func route(proxy *Proxy, name string, serverProto stamps.StampProtoType) (*Relay
 		}
 	}
 	if len(relayStamps) == 0 {
-		dlog.Warnf("Empty relay set for [%v]", name)
-		return nil, nil
+		err := fmt.Errorf("Non-existent relay set for server [%v]", name)
+		dlog.Warn(err)
+		return nil, err
 	}
 	var relayCandidateStamp *stamps.ServerStamp
 	if !wildcard || len(relayStamps) == 1 {

Original file line number	Diff line number	Diff line change
`@@ -467,8 +467,9 @@ func route(proxy Proxy, name string, serverProto stamps.StampProtoType) (Relay`
`467`	`467`	`}`
`468`	`468`	`}`
`469`	`469`	`if len(relayStamps) == 0 {`
`470`		`- dlog.Warnf("Empty relay set for [%v]", name)`
`471`		`- return nil, nil`
	`470`	`+ err := fmt.Errorf("Non-existent relay set for server [%v]", name)`
	`471`	`+ dlog.Warn(err)`
	`472`	`+ return nil, err`
`472`	`473`	`}`
`473`	`474`	`var relayCandidateStamp *stamps.ServerStamp`
`474`	`475`	`if !wildcard \|\| len(relayStamps) == 1 {`