Use SimpleEWMA for the question size estimator

jedisct1 · jedisct1 · commit 9373cc716254 · 2022-02-20T23:40:32.000+01:00
diff --git a/dnscrypt-proxy/estimators.go b/dnscrypt-proxy/estimators.go
@@ -6,18 +6,14 @@ import (
 	"github.com/jedisct1/ewma"
 )
 
-const (
-	SizeEstimatorEwmaDecay = 100.0
-)
-
 type QuestionSizeEstimator struct {
 	sync.RWMutex
 	minQuestionSize int
 	ewma            ewma.MovingAverage
 }
 
 func NewQuestionSizeEstimator() QuestionSizeEstimator {
-	return QuestionSizeEstimator{minQuestionSize: InitialMinQuestionSize, ewma: ewma.NewMovingAverage(SizeEstimatorEwmaDecay)}
+	return QuestionSizeEstimator{minQuestionSize: InitialMinQuestionSize, ewma: &ewma.SimpleEWMA{}}
 }
 
 func (questionSizeEstimator *QuestionSizeEstimator) MinQuestionSize() int {

Original file line number	Diff line number	Diff line change
`@@ -6,18 +6,14 @@ import (`
`6`	`6`	`"github.com/jedisct1/ewma"`
`7`	`7`	`)`
`8`	`8`
`9`		`-const (`
`10`		`- SizeEstimatorEwmaDecay = 100.0`
`11`		`-)`
`12`		`-`
`13`	`9`	`type QuestionSizeEstimator struct {`
`14`	`10`	`sync.RWMutex`
`15`	`11`	`minQuestionSize int`
`16`	`12`	`ewma ewma.MovingAverage`
`17`	`13`	`}`
`18`	`14`
`19`	`15`	`func NewQuestionSizeEstimator() QuestionSizeEstimator {`
`20`		`- return QuestionSizeEstimator{minQuestionSize: InitialMinQuestionSize, ewma: ewma.NewMovingAverage(SizeEstimatorEwmaDecay)}`
	`16`	`+ return QuestionSizeEstimator{minQuestionSize: InitialMinQuestionSize, ewma: &ewma.SimpleEWMA{}}`
`21`	`17`	`}`
`22`	`18`
`23`	`19`	`func (questionSizeEstimator *QuestionSizeEstimator) MinQuestionSize() int {`