Skip to content

Commit f67e9ca

Browse files
author
livingentity
authored
regression: fix ewma warmup again (#2079)
* Update estimators.go * Update go.mod * Update modules.txt * Update go.sum * Update serversInfo.go * Update estimators.go * Update serversInfo.go
1 parent 5d023d2 commit f67e9ca

5 files changed

Lines changed: 11 additions & 10 deletions

File tree

dnscrypt-proxy/estimators.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package main
33
import (
44
"sync"
55

6-
"github.com/lifenjoiner/ewma"
6+
"github.com/jedisct1/ewma"
77
)
88

99
const (
@@ -13,7 +13,7 @@ const (
1313
type QuestionSizeEstimator struct {
1414
sync.RWMutex
1515
minQuestionSize int
16-
ewma *ewma.EWMA
16+
ewma ewma.MovingAverage
1717
}
1818

1919
func NewQuestionSizeEstimator() QuestionSizeEstimator {

dnscrypt-proxy/serversInfo.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ import (
1616
"time"
1717

1818
"github.com/jedisct1/dlog"
19+
"github.com/jedisct1/ewma"
1920
clocksmith "github.com/jedisct1/go-clocksmith"
2021
stamps "github.com/jedisct1/go-dnsstamps"
21-
"github.com/lifenjoiner/ewma"
2222
"github.com/miekg/dns"
2323
"golang.org/x/crypto/ed25519"
2424
)
@@ -46,7 +46,7 @@ type DOHClientCreds struct {
4646
type ServerInfo struct {
4747
DOHClientCreds DOHClientCreds
4848
lastActionTS time.Time
49-
rtt *ewma.EWMA
49+
rtt ewma.MovingAverage
5050
Name string
5151
HostName string
5252
UDPAddr *net.UDPAddr
@@ -199,6 +199,7 @@ func (serversInfo *ServersInfo) refreshServer(proxy *Proxy, name string, stamp s
199199
dlog.Fatalf("[%s] != [%s]", name, newServer.Name)
200200
}
201201
newServer.rtt = ewma.NewMovingAverage(RTTEwmaDecay)
202+
newServer.rtt.SetWarmupSamples(1)
202203
newServer.rtt.Set(float64(newServer.initialRtt))
203204
isNew = true
204205
serversInfo.Lock()

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@ require (
1010
github.com/hashicorp/golang-lru v0.5.4
1111
github.com/hectane/go-acl v0.0.0-20190604041725-da78bae5fc95
1212
github.com/jedisct1/dlog v0.0.0-20210927135244-3381aa132e7f
13+
github.com/jedisct1/ewma v1.2.1-0.20220220223311-a30af446ecb9
1314
github.com/jedisct1/go-clocksmith v0.0.0-20210101121932-da382b963868
1415
github.com/jedisct1/go-dnsstamps v0.0.0-20220328103132-6fb2da762370
1516
github.com/jedisct1/go-hpke-compact v0.0.0-20210930135406-0763750339f0
1617
github.com/jedisct1/go-minisign v0.0.0-20211028175153-1c139d1cc84b
1718
github.com/jedisct1/xsecretbox v0.0.0-20210927135450-ebe41aef7bef
1819
github.com/k-sone/critbitgo v1.4.0
1920
github.com/kardianos/service v1.2.1
20-
github.com/lifenjoiner/ewma v0.0.0-20210320054258-4f227d7eb8a2
2121
github.com/miekg/dns v1.1.47
2222
github.com/powerman/check v1.6.0
2323
golang.org/x/crypto v0.0.0-20220321153916-2c7772ba3064

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,8 @@ github.com/inconshreveable/mousetrap v1.0.0 h1:Z8tu5sraLXCXIcARxBp/8cbvlwVa7Z1NH
350350
github.com/inconshreveable/mousetrap v1.0.0/go.mod h1:PxqpIevigyE2G7u3NXJIT2ANytuPF1OarO4DADm73n8=
351351
github.com/jedisct1/dlog v0.0.0-20210927135244-3381aa132e7f h1:XICcphytniQKdtd4FGrK0b1ERzS7FBvFtVUCReSppmU=
352352
github.com/jedisct1/dlog v0.0.0-20210927135244-3381aa132e7f/go.mod h1:35aII3PkLMvmc8daWy0vcZXDU+a40lJczHHTFRJmnvw=
353+
github.com/jedisct1/ewma v1.2.1-0.20220220223311-a30af446ecb9 h1:U5QPCoM1KkMJ9RfEfP0joKNwwwIHG1oP9RzjvQTuh98=
354+
github.com/jedisct1/ewma v1.2.1-0.20220220223311-a30af446ecb9/go.mod h1:qCWdft6DX9wxyNsUS+sxS44UkxE7eQnNtBttTWoW0cU=
353355
github.com/jedisct1/go-clocksmith v0.0.0-20210101121932-da382b963868 h1:QZ79mRbNwYYYmiVjyv+X0NKgYE6nyN1yo3gtEFdzpiE=
354356
github.com/jedisct1/go-clocksmith v0.0.0-20210101121932-da382b963868/go.mod h1:SAINchklztk2jcLWJ4bpNF4KnwDUSUTX+cJbspWC2Rw=
355357
github.com/jedisct1/go-dnsstamps v0.0.0-20220328103132-6fb2da762370 h1:VQyy4FYgkGVvMnfMauP3phjlwmQQu+DxnE5jBBH4It8=
@@ -421,8 +423,6 @@ github.com/letsencrypt/pkcs11key/v4 v4.0.0/go.mod h1:EFUvBDay26dErnNb70Nd0/VW3tJ
421423
github.com/lib/pq v1.0.0/go.mod h1:5WUZQaWbwv1U+lTReE5YruASi9Al49XbQIvNi/34Woo=
422424
github.com/lib/pq v1.8.0/go.mod h1:AlVN5x4E4T544tWzH6hKfbfQvm3HdbOxrmggDNAPY9o=
423425
github.com/lib/pq v1.9.0/go.mod h1:AlVN5x4E4T544tWzH6hKfbfQvm3HdbOxrmggDNAPY9o=
424-
github.com/lifenjoiner/ewma v0.0.0-20210320054258-4f227d7eb8a2 h1:eD3+F7WMC7wryFGBrLSyzoRqK+kR7nCT/9VT2E3XJzc=
425-
github.com/lifenjoiner/ewma v0.0.0-20210320054258-4f227d7eb8a2/go.mod h1:SJvYtJnDKXqTrIvyRocCJmuNuM3bUb4krn9UbZXj+tw=
426426
github.com/logrusorgru/aurora v0.0.0-20181002194514-a7b3b318ed4e/go.mod h1:7rIyQOR62GCctdiQpZ/zOJlFyk6y+94wXzv6RNZgaR4=
427427
github.com/magiconair/properties v1.8.0/go.mod h1:PppfXfuXeibc/6YijjN8zIbojt8czPbwD3XqdrwzmxQ=
428428
github.com/magiconair/properties v1.8.1 h1:ZC2Vc7/ZFkGmsVC9KvOjumD+G5lXy2RtTKyzRKO2BQ4=

vendor/modules.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,9 @@ github.com/inconshreveable/mousetrap
248248
# github.com/jedisct1/dlog v0.0.0-20210927135244-3381aa132e7f
249249
## explicit; go 1.17
250250
github.com/jedisct1/dlog
251+
# github.com/jedisct1/ewma v1.2.1-0.20220220223311-a30af446ecb9
252+
## explicit; go 1.12
253+
github.com/jedisct1/ewma
251254
# github.com/jedisct1/go-clocksmith v0.0.0-20210101121932-da382b963868
252255
## explicit
253256
github.com/jedisct1/go-clocksmith
@@ -303,9 +306,6 @@ github.com/ldez/gomoddirectives
303306
# github.com/ldez/tagliatelle v0.2.0
304307
## explicit; go 1.16
305308
github.com/ldez/tagliatelle
306-
# github.com/lifenjoiner/ewma v0.0.0-20210320054258-4f227d7eb8a2
307-
## explicit; go 1.16
308-
github.com/lifenjoiner/ewma
309309
# github.com/magiconair/properties v1.8.1
310310
## explicit
311311
github.com/magiconair/properties

0 commit comments

Comments
 (0)