Skip to content

Commit d7d6815

Browse files
authored
ci: migrate CI secrets from AWS SSM to Vault KV (#1145)
## Summary - Migrate `get_secrets.sh` from `aws ssm get-parameter` to `vault kv get`, matching the pattern used by `datadog-lambda-js` - Remove `DATADOG_API_SECRET_ARN` from CI secrets — the ARN is a public resource identifier, not sensitive data - Hardcode the Secrets Manager ARN directly in `integration-tests/lib/util.ts` ## Test plan - [ ] Verify CI pipeline can fetch secrets from Vault KV at `kv/k8s/gitlab-runner/datadog-lambda-extension/secrets` - [ ] Verify integration tests pass with the hardcoded secret ARN - [ ] Confirm `DD_API_KEY`, `DD_APP_KEY`, and external ID are correctly resolved
1 parent 0d19e53 commit d7d6815

2 files changed

Lines changed: 4 additions & 28 deletions

File tree

.gitlab/scripts/get_secrets.sh

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -21,39 +21,15 @@ fi
2121

2222
printf "Getting AWS External ID...\n"
2323

24-
EXTERNAL_ID=$(aws ssm get-parameter \
25-
--region us-east-1 \
26-
--name "ci.datadog-lambda-extension.$EXTERNAL_ID_NAME" \
27-
--with-decryption \
28-
--query "Parameter.Value" \
29-
--out text)
24+
EXTERNAL_ID=$(vault kv get -field="$EXTERNAL_ID_NAME" kv/k8s/gitlab-runner/datadog-lambda-extension/secrets)
3025

3126
printf "Getting DD API KEY...\n"
3227

33-
export DD_API_KEY=$(aws ssm get-parameter \
34-
--region us-east-1 \
35-
--name ci.datadog-lambda-extension.dd-api-key \
36-
--with-decryption \
37-
--query "Parameter.Value" \
38-
--out text)
39-
40-
printf "Getting DD API KEY Secret ARN...\n"
41-
42-
export DATADOG_API_SECRET_ARN=$(aws ssm get-parameter \
43-
--region us-east-1 \
44-
--name ci.datadog-lambda-extension.dd-api-key-secret-arn \
45-
--with-decryption \
46-
--query "Parameter.Value" \
47-
--out text)
28+
export DD_API_KEY=$(vault kv get -field=dd-api-key kv/k8s/gitlab-runner/datadog-lambda-extension/secrets)
4829

4930
printf "Getting DD APP KEY...\n"
5031

51-
export DD_APP_KEY=$(aws ssm get-parameter \
52-
--region us-east-1 \
53-
--name ci.datadog-lambda-extension.dd-app-key \
54-
--with-decryption \
55-
--query "Parameter.Value" \
56-
--out text)
32+
export DD_APP_KEY=$(vault kv get -field=dd-app-key kv/k8s/gitlab-runner/datadog-lambda-extension/secrets)
5733

5834
printf "Assuming role...\n"
5935

integration-tests/lib/util.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import * as lambda from 'aws-cdk-lib/aws-lambda';
66
import { LayerVersion } from "aws-cdk-lib/aws-lambda";
77
import {ACCOUNT, REGION} from "../config";
88

9-
export const datadogSecretArn = process.env.DATADOG_API_SECRET_ARN!;
9+
export const datadogSecretArn = 'arn:aws:secretsmanager:us-east-1:425362996713:secret:extension-integration-tests-api-key-PnEPHz';
1010
export const extensionLayerArn = process.env.EXTENSION_LAYER_ARN!;
1111

1212
export const defaultNodeRuntime = lambda.Runtime.NODEJS_24_X;

0 commit comments

Comments
 (0)