Skip to content

Commit c8ee93b

Browse files
jchrostek-ddclaude
jchrostek-dd
and
claude
authored
Add span.kind=server to aws.lambda spans (#743)
* Add span.kind=server to aws.lambda span This aligns the tracer-created span with the extension's behavior, enabling server-based features in Datadog APM for Lambda functions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Update integration test snapshots to include span.kind: server Add span.kind: server tag to aws.lambda spans in snapshot files for esm, process-input-traced, and status-code-500s tests across all Node.js versions (18, 20, 22, 24). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Add span.kind=server to warm start spans in snapshots * Fix duplicate span.kind entries in esm snapshots --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
1 parent e4bdd73 commit c8ee93b

14 files changed

Lines changed: 117 additions & 0 deletions

‎integration_tests/snapshots/logs/esm_node18.log‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ START
7373
"version": "1.0.0",
7474
"runtime-id":"XXXX",
7575
"cold_start": "true",
76+
"span.kind": "server",
7677
"function_arn":"XXXX_node18",
7778
"function_version": "$LATEST",
7879
"request_id":"XXXX",
@@ -179,6 +180,7 @@ START
179180
"version": "1.0.0",
180181
"runtime-id":"XXXX",
181182
"cold_start": "false",
183+
"span.kind": "server",
182184
"function_arn":"XXXX_node18",
183185
"function_version": "$LATEST",
184186
"request_id":"XXXX",
@@ -282,6 +284,7 @@ START
282284
"version": "1.0.0",
283285
"runtime-id":"XXXX",
284286
"cold_start": "false",
287+
"span.kind": "server",
285288
"function_arn":"XXXX_node18",
286289
"function_version": "$LATEST",
287290
"request_id":"XXXX",
@@ -385,6 +388,7 @@ START
385388
"version": "1.0.0",
386389
"runtime-id":"XXXX",
387390
"cold_start": "false",
391+
"span.kind": "server",
388392
"function_arn":"XXXX_node18",
389393
"function_version": "$LATEST",
390394
"request_id":"XXXX",
@@ -487,6 +491,7 @@ START
487491
"version": "1.0.0",
488492
"runtime-id":"XXXX",
489493
"cold_start": "false",
494+
"span.kind": "server",
490495
"function_arn":"XXXX_node18",
491496
"function_version": "$LATEST",
492497
"request_id":"XXXX",
@@ -589,6 +594,7 @@ START
589594
"version": "1.0.0",
590595
"runtime-id":"XXXX",
591596
"cold_start": "false",
597+
"span.kind": "server",
592598
"function_arn":"XXXX_node18",
593599
"function_version": "$LATEST",
594600
"request_id":"XXXX",
@@ -691,6 +697,7 @@ START
691697
"version": "1.0.0",
692698
"runtime-id":"XXXX",
693699
"cold_start": "false",
700+
"span.kind": "server",
694701
"function_arn":"XXXX_node18",
695702
"function_version": "$LATEST",
696703
"request_id":"XXXX",
@@ -792,6 +799,7 @@ START
792799
"version": "1.0.0",
793800
"runtime-id":"XXXX",
794801
"cold_start": "false",
802+
"span.kind": "server",
795803
"function_arn":"XXXX_node18",
796804
"function_version": "$LATEST",
797805
"request_id":"XXXX",
@@ -892,6 +900,7 @@ START
892900
"version": "1.0.0",
893901
"runtime-id":"XXXX",
894902
"cold_start": "false",
903+
"span.kind": "server",
895904
"function_arn":"XXXX_node18",
896905
"function_version": "$LATEST",
897906
"request_id":"XXXX",

‎integration_tests/snapshots/logs/esm_node20.log‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ START
7373
"version": "1.0.0",
7474
"runtime-id":"XXXX",
7575
"cold_start": "true",
76+
"span.kind": "server",
7677
"function_arn":"XXXX_node20",
7778
"function_version": "$LATEST",
7879
"request_id":"XXXX",
@@ -179,6 +180,7 @@ START
179180
"version": "1.0.0",
180181
"runtime-id":"XXXX",
181182
"cold_start": "false",
183+
"span.kind": "server",
182184
"function_arn":"XXXX_node20",
183185
"function_version": "$LATEST",
184186
"request_id":"XXXX",
@@ -282,6 +284,7 @@ START
282284
"version": "1.0.0",
283285
"runtime-id":"XXXX",
284286
"cold_start": "false",
287+
"span.kind": "server",
285288
"function_arn":"XXXX_node20",
286289
"function_version": "$LATEST",
287290
"request_id":"XXXX",
@@ -385,6 +388,7 @@ START
385388
"version": "1.0.0",
386389
"runtime-id":"XXXX",
387390
"cold_start": "false",
391+
"span.kind": "server",
388392
"function_arn":"XXXX_node20",
389393
"function_version": "$LATEST",
390394
"request_id":"XXXX",
@@ -487,6 +491,7 @@ START
487491
"version": "1.0.0",
488492
"runtime-id":"XXXX",
489493
"cold_start": "false",
494+
"span.kind": "server",
490495
"function_arn":"XXXX_node20",
491496
"function_version": "$LATEST",
492497
"request_id":"XXXX",
@@ -589,6 +594,7 @@ START
589594
"version": "1.0.0",
590595
"runtime-id":"XXXX",
591596
"cold_start": "false",
597+
"span.kind": "server",
592598
"function_arn":"XXXX_node20",
593599
"function_version": "$LATEST",
594600
"request_id":"XXXX",
@@ -691,6 +697,7 @@ START
691697
"version": "1.0.0",
692698
"runtime-id":"XXXX",
693699
"cold_start": "false",
700+
"span.kind": "server",
694701
"function_arn":"XXXX_node20",
695702
"function_version": "$LATEST",
696703
"request_id":"XXXX",
@@ -792,6 +799,7 @@ START
792799
"version": "1.0.0",
793800
"runtime-id":"XXXX",
794801
"cold_start": "false",
802+
"span.kind": "server",
795803
"function_arn":"XXXX_node20",
796804
"function_version": "$LATEST",
797805
"request_id":"XXXX",
@@ -892,6 +900,7 @@ START
892900
"version": "1.0.0",
893901
"runtime-id":"XXXX",
894902
"cold_start": "false",
903+
"span.kind": "server",
895904
"function_arn":"XXXX_node20",
896905
"function_version": "$LATEST",
897906
"request_id":"XXXX",

‎integration_tests/snapshots/logs/esm_node22.log‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ START
7373
"version": "1.0.0",
7474
"runtime-id":"XXXX",
7575
"cold_start": "true",
76+
"span.kind": "server",
7677
"function_arn":"XXXX_node22",
7778
"function_version": "$LATEST",
7879
"request_id":"XXXX",
@@ -179,6 +180,7 @@ START
179180
"version": "1.0.0",
180181
"runtime-id":"XXXX",
181182
"cold_start": "false",
183+
"span.kind": "server",
182184
"function_arn":"XXXX_node22",
183185
"function_version": "$LATEST",
184186
"request_id":"XXXX",
@@ -282,6 +284,7 @@ START
282284
"version": "1.0.0",
283285
"runtime-id":"XXXX",
284286
"cold_start": "false",
287+
"span.kind": "server",
285288
"function_arn":"XXXX_node22",
286289
"function_version": "$LATEST",
287290
"request_id":"XXXX",
@@ -385,6 +388,7 @@ START
385388
"version": "1.0.0",
386389
"runtime-id":"XXXX",
387390
"cold_start": "false",
391+
"span.kind": "server",
388392
"function_arn":"XXXX_node22",
389393
"function_version": "$LATEST",
390394
"request_id":"XXXX",
@@ -487,6 +491,7 @@ START
487491
"version": "1.0.0",
488492
"runtime-id":"XXXX",
489493
"cold_start": "false",
494+
"span.kind": "server",
490495
"function_arn":"XXXX_node22",
491496
"function_version": "$LATEST",
492497
"request_id":"XXXX",
@@ -589,6 +594,7 @@ START
589594
"version": "1.0.0",
590595
"runtime-id":"XXXX",
591596
"cold_start": "false",
597+
"span.kind": "server",
592598
"function_arn":"XXXX_node22",
593599
"function_version": "$LATEST",
594600
"request_id":"XXXX",
@@ -691,6 +697,7 @@ START
691697
"version": "1.0.0",
692698
"runtime-id":"XXXX",
693699
"cold_start": "false",
700+
"span.kind": "server",
694701
"function_arn":"XXXX_node22",
695702
"function_version": "$LATEST",
696703
"request_id":"XXXX",
@@ -792,6 +799,7 @@ START
792799
"version": "1.0.0",
793800
"runtime-id":"XXXX",
794801
"cold_start": "false",
802+
"span.kind": "server",
795803
"function_arn":"XXXX_node22",
796804
"function_version": "$LATEST",
797805
"request_id":"XXXX",
@@ -892,6 +900,7 @@ START
892900
"version": "1.0.0",
893901
"runtime-id":"XXXX",
894902
"cold_start": "false",
903+
"span.kind": "server",
895904
"function_arn":"XXXX_node22",
896905
"function_version": "$LATEST",
897906
"request_id":"XXXX",

‎integration_tests/snapshots/logs/esm_node24.log‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ START
7373
"version": "1.0.0",
7474
"runtime-id":"XXXX",
7575
"cold_start": "true",
76+
"span.kind": "server",
7677
"function_arn":"XXXX_node24",
7778
"function_version": "$LATEST",
7879
"request_id":"XXXX",
@@ -179,6 +180,7 @@ START
179180
"version": "1.0.0",
180181
"runtime-id":"XXXX",
181182
"cold_start": "false",
183+
"span.kind": "server",
182184
"function_arn":"XXXX_node24",
183185
"function_version": "$LATEST",
184186
"request_id":"XXXX",
@@ -282,6 +284,7 @@ START
282284
"version": "1.0.0",
283285
"runtime-id":"XXXX",
284286
"cold_start": "false",
287+
"span.kind": "server",
285288
"function_arn":"XXXX_node24",
286289
"function_version": "$LATEST",
287290
"request_id":"XXXX",
@@ -385,6 +388,7 @@ START
385388
"version": "1.0.0",
386389
"runtime-id":"XXXX",
387390
"cold_start": "false",
391+
"span.kind": "server",
388392
"function_arn":"XXXX_node24",
389393
"function_version": "$LATEST",
390394
"request_id":"XXXX",
@@ -487,6 +491,7 @@ START
487491
"version": "1.0.0",
488492
"runtime-id":"XXXX",
489493
"cold_start": "false",
494+
"span.kind": "server",
490495
"function_arn":"XXXX_node24",
491496
"function_version": "$LATEST",
492497
"request_id":"XXXX",
@@ -589,6 +594,7 @@ START
589594
"version": "1.0.0",
590595
"runtime-id":"XXXX",
591596
"cold_start": "false",
597+
"span.kind": "server",
592598
"function_arn":"XXXX_node24",
593599
"function_version": "$LATEST",
594600
"request_id":"XXXX",
@@ -691,6 +697,7 @@ START
691697
"version": "1.0.0",
692698
"runtime-id":"XXXX",
693699
"cold_start": "false",
700+
"span.kind": "server",
694701
"function_arn":"XXXX_node24",
695702
"function_version": "$LATEST",
696703
"request_id":"XXXX",
@@ -792,6 +799,7 @@ START
792799
"version": "1.0.0",
793800
"runtime-id":"XXXX",
794801
"cold_start": "false",
802+
"span.kind": "server",
795803
"function_arn":"XXXX_node24",
796804
"function_version": "$LATEST",
797805
"request_id":"XXXX",
@@ -892,6 +900,7 @@ START
892900
"version": "1.0.0",
893901
"runtime-id":"XXXX",
894902
"cold_start": "false",
903+
"span.kind": "server",
895904
"function_arn":"XXXX_node24",
896905
"function_version": "$LATEST",
897906
"request_id":"XXXX",

‎integration_tests/snapshots/logs/process-input-traced_node18.log‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ START
8080
"version": "1.0.0",
8181
"runtime-id":"XXXX",
8282
"cold_start": "true",
83+
"span.kind": "server",
8384
"function_arn":"XXXX_node18",
8485
"function_version": "$LATEST",
8586
"request_id":"XXXX",
@@ -245,6 +246,7 @@ START
245246
"version": "1.0.0",
246247
"runtime-id":"XXXX",
247248
"cold_start": "false",
249+
"span.kind": "server",
248250
"function_arn":"XXXX_node18",
249251
"function_version": "$LATEST",
250252
"request_id":"XXXX",
@@ -403,6 +405,7 @@ START
403405
"version": "1.0.0",
404406
"runtime-id":"XXXX",
405407
"cold_start": "false",
408+
"span.kind": "server",
406409
"function_arn":"XXXX_node18",
407410
"function_version": "$LATEST",
408411
"request_id":"XXXX",
@@ -561,6 +564,7 @@ START
561564
"version": "1.0.0",
562565
"runtime-id":"XXXX",
563566
"cold_start": "false",
567+
"span.kind": "server",
564568
"function_arn":"XXXX_node18",
565569
"function_version": "$LATEST",
566570
"request_id":"XXXX",
@@ -718,6 +722,7 @@ START
718722
"version": "1.0.0",
719723
"runtime-id":"XXXX",
720724
"cold_start": "false",
725+
"span.kind": "server",
721726
"function_arn":"XXXX_node18",
722727
"function_version": "$LATEST",
723728
"request_id":"XXXX",
@@ -854,6 +859,7 @@ START
854859
"version": "1.0.0",
855860
"runtime-id":"XXXX",
856861
"cold_start": "false",
862+
"span.kind": "server",
857863
"function_arn":"XXXX_node18",
858864
"function_version": "$LATEST",
859865
"request_id":"XXXX",
@@ -990,6 +996,7 @@ START
990996
"version": "1.0.0",
991997
"runtime-id":"XXXX",
992998
"cold_start": "false",
999+
"span.kind": "server",
9931000
"function_arn":"XXXX_node18",
9941001
"function_version": "$LATEST",
9951002
"request_id":"XXXX",
@@ -1125,6 +1132,7 @@ START
11251132
"version": "1.0.0",
11261133
"runtime-id":"XXXX",
11271134
"cold_start": "false",
1135+
"span.kind": "server",
11281136
"function_arn":"XXXX_node18",
11291137
"function_version": "$LATEST",
11301138
"request_id":"XXXX",
@@ -1259,6 +1267,7 @@ START
12591267
"version": "1.0.0",
12601268
"runtime-id":"XXXX",
12611269
"cold_start": "false",
1270+
"span.kind": "server",
12621271
"function_arn":"XXXX_node18",
12631272
"function_version": "$LATEST",
12641273
"request_id":"XXXX",

0 commit comments

Comments
 (0)