Skip to content

Commit d7a4a40

Browse files
authored
add explicit dependency on opentelemetry api (#719)
1 parent 378e174 commit d7a4a40

4 files changed

Lines changed: 15 additions & 2 deletions

File tree

Dockerfile

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ RUN rm -rf /nodejs/node_modules/aws-sdk
3232
RUN rm -rf /nodejs/node_modules/aws-xray-sdk-core/node_modules/aws-sdk
3333

3434
# Remove heavy files from @datadog/pprof which aren't used in a lambda environment
35+
# TODO: Ship individual bindings per platform and depend on that instead.
36+
# TODO: Split x64 and ARM so that each image only has the binaries for its architecture.
3537
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/darwin-arm64
3638
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/darwin-x64
3739
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/linux-arm
@@ -44,5 +46,12 @@ RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/*/node-120.node
4446
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/*/node-131.node
4547
RUN rm -rf /nodejs/node_modules/@datadog/pprof/prebuilds/*/node-141.node
4648

49+
# Remove heavy files from @opentelemetry/api which aren't used in a lambda environment.
50+
# TODO: Create a completely separate Datadog scoped package for OpenTelemetry instead.
51+
RUN rm -rf /nodejs/node_modules/@opentelemetry/api/build/esm
52+
RUN rm -rf /nodejs/node_modules/@opentelemetry/api/build/esnext
53+
RUN rm -rf /nodejs/node_modules/@opentelemetry/api-logs/build/esm
54+
RUN rm -rf /nodejs/node_modules/@opentelemetry/api-logs/build/esnext
55+
4756
FROM scratch
4857
COPY --from=builder /nodejs /

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
"@aws-sdk/client-kms": "^3.366.0",
2424
"@aws-sdk/client-secrets-manager": "^3.721.0",
2525
"@datadog/pprof": "*",
26+
"@opentelemetry/api": "*",
27+
"@opentelemetry/api-logs": "*",
2628
"@types/aws-lambda": "^8.10.136",
2729
"@types/aws-sdk": "^2.7.0",
2830
"@types/jest": "^27.5.2",

scripts/move_ddtrace_dependency.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ const file = JSON.parse(process.argv[2]);
77

88
moveDependency('dd-trace')
99
moveDependency('@datadog/pprof')
10+
moveDependency('@opentelemetry/api')
11+
moveDependency('@opentelemetry/api-logs')
1012

1113
console.log(JSON.stringify(file, null, 2));
1214

yarn.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1429,14 +1429,14 @@
14291429
resolved "https://registry.yarnpkg.com/@openfeature/server-sdk/-/server-sdk-1.18.0.tgz#5fed5f1d0900b2535878db18a78295bbaebb997b"
14301430
integrity sha512-uP8nqEGBS58s3iWXx6d8vnJ6ZVt3DACJL4PWADOAuwIS4xXpID91783e9f6zQ0i1ijQpj3yx+3ZuCB2LfQMUMA==
14311431

1432-
"@opentelemetry/api-logs@<1.0.0":
1432+
"@opentelemetry/api-logs@*", "@opentelemetry/api-logs@<1.0.0":
14331433
version "0.208.0"
14341434
resolved "https://registry.yarnpkg.com/@opentelemetry/api-logs/-/api-logs-0.208.0.tgz#56d3891010a1fa1cf600ba8899ed61b43ace511c"
14351435
integrity sha512-CjruKY9V6NMssL/T1kAFgzosF1v9o6oeN+aX5JB/C/xPNtmgIJqcXHG7fA82Ou1zCpWGl4lROQUKwUNE1pMCyg==
14361436
dependencies:
14371437
"@opentelemetry/api" "^1.3.0"
14381438

1439-
"@opentelemetry/api@>=1.0.0 <1.10.0", "@opentelemetry/api@^1.3.0":
1439+
"@opentelemetry/api@*", "@opentelemetry/api@>=1.0.0 <1.10.0", "@opentelemetry/api@^1.3.0":
14401440
version "1.9.0"
14411441
resolved "https://registry.yarnpkg.com/@opentelemetry/api/-/api-1.9.0.tgz#d03eba68273dc0f7509e2a3d5cba21eae10379fe"
14421442
integrity sha512-3giAOQvZiH5F9bMlMiv8+GSPMeqg0dbaeo58/0SlA9sxSqZhnUtxzX9/2FzyhS9sWQf5S0GJE0AKBrFqjpeYcg==

0 commit comments

Comments
 (0)