Skip to content

Commit 2f640ef

Browse files
committed
Add service.
1 parent e2426f6 commit 2f640ef

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

datadog_lambda/config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ def as_bool(val):
2727

2828
class Config:
2929

30+
service = _get_env("DD_SERVICE")
3031
add_span_pointers = _get_env("DD_BOTOCORE_ADD_SPAN_POINTERS", "true", as_bool)
3132
cold_start_tracing = _get_env("DD_COLD_START_TRACING", "true", as_bool)
3233
enhanced_metrics_enabled = _get_env("DD_ENHANCED_METRICS", "true", as_bool)

datadog_lambda/wrapper.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,6 @@ def __init__(self, func):
158158
"""Executes when the wrapped function gets wrapped"""
159159
try:
160160
self.func = func
161-
self.service = os.environ.get(DD_SERVICE, None)
162161
self.extractor_env = os.environ.get(DD_TRACE_EXTRACTOR, None)
163162
self.trace_extractor = None
164163
self.span = None
@@ -200,7 +199,7 @@ def __init__(self, func):
200199
logger.debug(f"Malformatted for env {DD_COLD_START_TRACE_SKIP_LIB}")
201200
self.response = None
202201
if profiling_env_var:
203-
self.prof = profiler.Profiler(env=env_env_var, service=self.service)
202+
self.prof = profiler.Profiler(env=env_env_var, service=config.service)
204203
if self.extractor_env:
205204
extractor_parts = self.extractor_env.rsplit(".", 1)
206205
if len(extractor_parts) == 2:
@@ -367,8 +366,8 @@ def _after(self, event, context):
367366
if status_code:
368367
self.inferred_span.set_tag("http.status_code", status_code)
369368

370-
if self.service:
371-
self.inferred_span.set_tag("peer.service", self.service)
369+
if config.service:
370+
self.inferred_span.set_tag("peer.service", config.service)
372371

373372
if InferredSpanInfo.is_async(self.inferred_span) and self.span:
374373
self.inferred_span.finish(finish_time=self.span.start)

tests/test_config.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ def set_env(key, value):
1515

1616

1717
_test_config_from_environ = (
18+
("DD_SERVICE", "service", None, None),
19+
("DD_SERVICE", "service", "", ""),
20+
("DD_SERVICE", "service", "my_service", "my_service"),
1821
("AWS_LAMBDA_FUNCTION_NAME", "function_name", None, "function"),
1922
("AWS_LAMBDA_FUNCTION_NAME", "function_name", "", ""),
2023
("AWS_LAMBDA_FUNCTION_NAME", "function_name", "my_function", "my_function"),

0 commit comments

Comments
 (0)