Skip to content

Commit c4c3d8d

Browse files
committed
Add merge_xray_traces.
1 parent 91887a9 commit c4c3d8d

3 files changed

Lines changed: 12 additions & 6 deletions

File tree

datadog_lambda/config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ class Config:
4242
"DD_INSTRUMENTATION_TELEMETRY_ENABLED", "false", as_bool
4343
)
4444
trace_enabled = _get_env("DD_TRACE_ENABLED", "true", as_bool)
45+
merge_xray_traces = _get_env("DD_MERGE_XRAY_TRACES", "false", as_bool)
4546

4647
@property
4748
def fips_mode_enabled(self):

datadog_lambda/wrapper.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@
6464
logger = logging.getLogger(__name__)
6565

6666
DD_LOGS_INJECTION = "DD_LOGS_INJECTION"
67-
DD_MERGE_XRAY_TRACES = "DD_MERGE_XRAY_TRACES"
6867
AWS_LAMBDA_FUNCTION_NAME = "AWS_LAMBDA_FUNCTION_NAME"
6968
DD_LOCAL_TEST = "DD_LOCAL_TEST"
7069
DD_TRACE_EXTRACTOR = "DD_TRACE_EXTRACTOR"
@@ -160,9 +159,6 @@ def __init__(self, func):
160159
"""Executes when the wrapped function gets wrapped"""
161160
try:
162161
self.func = func
163-
self.merge_xray_traces = (
164-
os.environ.get(DD_MERGE_XRAY_TRACES, "false").lower() == "true"
165-
)
166162
self.function_name = os.environ.get(AWS_LAMBDA_FUNCTION_NAME, "function")
167163
self.service = os.environ.get(DD_SERVICE, None)
168164
self.extractor_env = os.environ.get(DD_TRACE_EXTRACTOR, None)
@@ -317,7 +313,7 @@ def _before(self, event, context):
317313
)
318314

319315
if config.trace_enabled:
320-
set_dd_trace_py_root(trace_context_source, self.merge_xray_traces)
316+
set_dd_trace_py_root(trace_context_source, config.merge_xray_traces)
321317
if self.make_inferred_span:
322318
self.inferred_span = create_inferred_span(
323319
event, context, event_source, self.decode_authorizer_context
@@ -330,7 +326,7 @@ def _before(self, event, context):
330326
is_cold_start=is_cold_start(),
331327
is_proactive_init=is_proactive_init(),
332328
trace_context_source=trace_context_source,
333-
merge_xray_traces=self.merge_xray_traces,
329+
merge_xray_traces=config.merge_xray_traces,
334330
trigger_tags=self.trigger_tags,
335331
parent_span=self.inferred_span,
336332
span_pointers=calculate_span_pointers(event_source, event),

tests/test_config.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,15 @@ def set_env(key, value):
115115
("DD_INSTRUMENTATION_TELEMETRY_ENABLED", "telemetry_enabled", "1", True), # CHANGED
116116
("DD_INSTRUMENTATION_TELEMETRY_ENABLED", "telemetry_enabled", "0", False),
117117
("DD_INSTRUMENTATION_TELEMETRY_ENABLED", "telemetry_enabled", "purple", False),
118+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", None, False),
119+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "", False),
120+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "true", True),
121+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "TRUE", True),
122+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "false", False),
123+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "FALSE", False),
124+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "1", True), # CHANGED
125+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "0", False),
126+
("DD_MERGE_XRAY_TRACES", "merge_xray_traces", "purple", False),
118127
)
119128

120129

0 commit comments

Comments
 (0)