Commit 2d96876
committed
Wire up with_new_state with DataSource (apache#20718)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
`ExecutionPlan::with_new_state()` allows devs to inject custom
information in their nodes that they can use for tweaking their
`ExecutionPlan` implementations.
This mechanism does not work today if the `ExecutionPlan` is a
`DataSourceExec`, as this one does not implement the `with_new_state()`
method from `ExecutionPlan`.
In order to let people use this also for their own `DataSource`
implementations, this PR adds this method to it.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
Propagates `with_new_state()` to the `DataSource` trait, so that custom
`DataSourceExec` can also benefit from it.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
As it's just method plumbing, my impression is that having a test for it
is overkill.
## Are there any user-facing changes?
Users can now implement their `with_new_state()` also in `DataSource`,
not only in `ExecutionPlan`
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
(cherry picked from commit 46ac990)1 parent 42ecad5 commit 2d96876
1 file changed
Lines changed: 28 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
214 | 230 | | |
215 | 231 | | |
216 | 232 | | |
| |||
407 | 423 | | |
408 | 424 | | |
409 | 425 | | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
410 | 438 | | |
411 | 439 | | |
412 | 440 | | |
| |||
0 commit comments