improved http error handling.

Author: shinin-light

src/deepcode/lib/modules/BundlesModule.ts

@@ -134,7 +134,13 @@ abstract class BundlesModule extends LoginModule
 
   // procesing filter list of files, acceptable for server
   public async createFilesFilterList(): Promise<void> {
-    this.serverFilesFilterList = await http.getFilters(this.baseURL, this.token);
+    try {
+      this.serverFilesFilterList = await http.getFilters(this.baseURL, this.token);
+    } catch (err) {
+      this.processError(err, {
+        message: errorsLogs.filtersFiles
+      })
+    }
   }
 
   private terminateAnalysis(): void {
@@ -195,7 +201,11 @@ abstract class BundlesModule extends LoginModule
       this.onError(error);
     });
 
-    http.analyse(this.baseURL, this.token, path, this.files, removedFiles).catch((error) => this.onError(error));
+    http.analyse(this.baseURL, this.token, path, this.files, removedFiles).catch(
+      (error) => this.processError(error, {
+        message: errorsLogs.analyse
+      })
+    );
   }
 
   private async startCollectingFiles(

src/deepcode/lib/modules/LoginModule.ts

@@ -38,7 +38,13 @@ abstract class LoginModule extends ReportModule implements DeepCode.LoginModuleI
   async checkSession(): Promise<boolean> {
     let validSession = false;
     if (this.token) {
-      validSession = !!(await http.checkSession(this.baseURL, this.token));
+      try {
+        validSession = !!(await http.checkSession(this.baseURL, this.token));
+      } catch (err) {
+        this.processError(err, {
+          message: errorsLogs.loginStatus
+        });
+      }
     }
     await setContext(DEEPCODE_CONTEXT.LOGGEDIN, validSession);
     return validSession;

src/deepcode/lib/modules/ReportModule.ts

@@ -24,21 +24,37 @@ abstract class ReportModule extends BaseDeepCodeModule implements DeepCode.Repor
 
   async sendError(options: {[key: string]: any}): Promise<void> {
     if (!this.shouldReport || !this.shouldReportErrors) return;
-    await http.sendError(this.baseURL, {
-      source: this.source,
-      ...(this.token && { sessionToken: this.token }),
-      ...options
-    });
+    try {
+      await http.sendError(this.baseURL, {
+        source: this.source,
+        ...(this.token && { sessionToken: this.token }),
+        ...options
+      });
+    } catch(error) {
+      console.error(error);
+    }
   }
 
   async sendEvent(event: string, options: {[key: string]: any}): Promise<void> {
     if (!this.shouldReport || !this.shouldReportEvents) return;
-    await http.sendEvent(this.baseURL, {
-      type: event,
-      source: this.source,
-      ...(this.token && { sessionToken: this.token }),
-      ...options
-    });
+    try {
+      await http.sendEvent(this.baseURL, {
+        type: event,
+        source: this.source,
+        ...(this.token && { sessionToken: this.token }),
+        ...options
+      });
+    } catch(error) {
+      this.processError(error, {
+        message: errorsLogs.sendEvent,
+        data: {
+          event,
+          source: this.source,
+          ...(this.token && { sessionToken: this.token }),
+          ...options
+        },
+      });
+    }
   }
 
   async processError(

src/deepcode/messages/errorsServerLogMessages.ts

@@ -1,6 +1,6 @@
 export const errorsLogs = {
   login: "Login of new user has failed",
-  // loginStatus: "Check login status of user has failed",
+  loginStatus: "Failed to check user session on server",
   filtersFiles: "Failed fetching filters files for bundles from server",
   // createBundle: "Failed to create bundle on server",
   // uploadFiles: "Failed to upload missing files in bundle to server",
@@ -9,7 +9,7 @@ export const errorsLogs = {
   //   `Failed fetching bundle status on server after ${attempts} attempts`,
   // extendBundle: "Failed to extend bundle on server with files",
   // failedStatusOfAnalysis: "Analysis results have status FAILED",
-  // analyze: "Analysis request failed",
+  analyse: "ServiceAI analyse request failed",
   failedAnalysis: "Failed executing analysis",
   failedServiceAI: "ServiceAI returned an error",
   failedExecution: "Failed extension pipeline execution",
@@ -21,7 +21,8 @@ export const errorsLogs = {
   updateReviewPositions:
     "Failed to update review results positions while editing file",
   errorReportFail: "Failed to send error report",
-  modifiedFile: (type: string) => `Failed to handle file change of type ${type}`,
+  modifiedFile: (type: string) => `Failed to handle changes on file of type ${type}`,
   // vscodeFileChanges: "Failed to process vscode file content changes",
   command: (type: string) => `Failed to execute ${type} command`,
+  sendEvent: "Failed to send event to server",
 };