applied our own recommendation

Author: Arvid Paeglit

src/deepcode/lib/modules/LoginModule.ts

@@ -38,8 +38,8 @@ class LoginModule extends ReportModule implements DeepCode.LoginModuleInterface
     }
   }
 
-  public checkSession(): Promise<boolean> | boolean {
-    if (!this.token) return false;
+  public checkSession(): Promise<boolean> {
+    if (!this.token) return Promise.resolve(false);
     return http.checkSession(this.baseURL, this.token);
   }
 

src/interfaces/DeepCodeInterfaces.ts

@@ -212,7 +212,7 @@ namespace DeepCode {
 
   export interface LoginModuleInterface {
     initiateLogin(): Promise<void>;
-    checkSession(): Promise<boolean> | boolean;
+    checkSession(): Promise<boolean>;
   }
 
   export interface BundlesModuleInterface {