Big refactoring. moving parts, that must be in 'tsc' to tsc

Author: Arvid Paeglit

.editorconfig

@@ -0,0 +1,21 @@
+# EditorConfig is awesome: https://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+# Unix-style newlines with a newline ending every file
+[*]
+end_of_line = lf
+insert_final_newline = true
+charset = utf-8
+trim_trailing_whitespace = true
+max_line_length = 120
+
+[*.{js,jsx,ts,tsx,vue,sass}]
+indent_style = space
+indent_size = 2
+
+# 4 space indentation
+[*.py]
+indent_style = space
+indent_size = 4

.eslintrc.js

@@ -8,11 +8,11 @@ module.exports = {
     'Atomics': 'readonly',
     'SharedArrayBuffer': 'readonly'
   },
-  // 'parserOptions': {
-  //   'ecmaVersion': 2018,
-  //   'sourceType': 'module',
-  //   'parser': 'babel-eslint'
-  // },
+  'parserOptions': {
+    'ecmaVersion': 2018,
+    'sourceType': 'module',
+    'parser': 'babel-eslint'
+  },
   'rules': {
     'no-console': process.env.NODE_ENV === 'production' ? 'error' : 'off',
     'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'off',
@@ -28,6 +28,10 @@ module.exports = {
     'padded-blocks': 'off',
     'camelcase': 'warn',
     'object-property-newline': 'off',
-    'indent': 'warn'
+    'prefer-const': 'off',
+    'import/no-absolute-path': 'off',
+    'no-prototype-builtins': 'off',
+    'indent': 'warn',
+    'quote-props': 'off'
   }
 }

package-lock.json

@@ -1,16 +1,3 @@
-export const HASH_ALGORITHM = "sha256";
-export const ENCODE_TYPE = "hex";
-export const FILE_FORMAT = "utf-8";
-export const GIT_FILENAME = ".git";
-export const GITIGNORE_FILENAME = ".gitignore";
-export const DCIGNORE_FILENAME = ".dcignore";
-export const EXCLUDED_NAMES = [
-  GIT_FILENAME,
-  GITIGNORE_FILENAME,
-  DCIGNORE_FILENAME,
-  ".vscode/"
-];
-
 export const FILE_CURRENT_STATUS = {
   modified: "modified",
   deleted: "deleted",

src/deepcode/constants/filesConstants.ts

@@ -1,7 +1,6 @@
 // Changing this requires changing display name in package.json.
 export const DEEPCODE_NAME = "DeepCode";
 export const DEEPCODE_EXTENSION_NAME = "deepcode";
-export const ALLOWED_PAYLOAD_SIZE = 1024 * 1024 * 4; // max payload size of 4MB in bytes
 export const MAX_CONNECTION_RETRIES = 5; // max number of automatic retries before showing an error
 export const IDE_NAME = "vscode";
 export const EXECUTION_DEBOUNCE_INTERVAL = 1000; // 1 second

src/deepcode/constants/general.ts

@@ -4,7 +4,7 @@ import * as _ from "lodash";
 import DeepCode from "../../../interfaces/DeepCodeInterfaces";
 import { IQueueAnalysisCheckResult } from "@deepcode/tsc";
 import { checkIfBundleIsEmpty } from "../../utils/bundlesUtils";
-import { createListOfDirFiles } from "../../utils/packageUtils";
+import { createListOfDirFiles } from "@deepcode/tsc/src/utils/packageUtils";
 import { BUNDLE_EVENTS } from "../../constants/events";
 import LoginModule from "../../lib/modules/LoginModule";
 import { DEEPCODE_ANALYSIS_STATUS, DEEPCODE_CONTEXT } from "../../constants/views";

src/deepcode/lib/modules/BundlesModule.ts

@@ -23,8 +23,7 @@ abstract class LoginModule extends ReportModule implements DeepCode.LoginModuleI
     try {
       const checkCurrentToken = await this.checkSession();
       if (checkCurrentToken) return;
-      const result = await this.serviceAI.startSession({ baseURL: this.baseURL, source: this.source });
-      const { sessionToken, loginURL } = result;
+      const { sessionToken, loginURL } = await this.serviceAI.startSession({ baseURL: this.baseURL, source: this.source });
       if (!sessionToken || !loginURL) {
         throw new Error(errorsLogs.login);
       }

src/deepcode/lib/modules/LoginModule.ts

@@ -1,9 +1,6 @@
 import * as vscode from "vscode";
-import { compareFileChanges, acceptFileToBundle, isFileChangingBundle } from "../../utils/filesUtils";
-import {
-  FILE_CURRENT_STATUS,
-  GIT_FILENAME
-} from "../../constants/filesConstants";
+import { compareFileChanges, isFileChangingBundle } from "@deepcode/tsc/src/utils/filesUtils";
+import { FILE_CURRENT_STATUS, GIT_FILENAME } from "@deepcode/tsc/src/constants/files";
 import { errorsLogs } from "../../messages/errorsServerLogMessages";
 import DeepCode from "../../../interfaces/DeepCodeInterfaces";
 
@@ -102,7 +99,7 @@ class DeepCodeFilesWatcher implements DeepCode.DeepCodeWatcherInterface {
           }
         } catch (err) {
           const filePathInBundle = filePath.split(fileWorkspacePath)[1];
-          
+
           await extension.processError(err, {
             message: errorsLogs.watchFileBeforeExtendBundle,
             bundleId: extension.remoteBundles[fileWorkspacePath].bundleId,
@@ -123,7 +120,7 @@ class DeepCodeFilesWatcher implements DeepCode.DeepCodeWatcherInterface {
     type: string
   ): Promise<void> {
     if (
-      !acceptFileToBundle(filePath, extension.serviceAI.serverFilesFilterList) &&
+      !extension.serviceAI.acceptFileToBundle(filePath) &&
       !isFileChangingBundle(filePath)
     ) {
       return;
@@ -189,7 +186,7 @@ class DeepCodeFilesWatcher implements DeepCode.DeepCodeWatcherInterface {
       ...(extension.serverFilesFilterList.extensions || []).map(e => `*${e}`),
       ...(extension.serverFilesFilterList.configFiles || [])
     ];
-    
+
     const globPattern: vscode.GlobPattern = `**/\{${watchFiles.join(',')}\}`;
     this.watcher = vscode.workspace.createFileSystemWatcher(globPattern);