lint related fixes. no logic changes

Author: Arvid Paeglit

.gitignore

@@ -6,3 +6,4 @@ yalc.lock
 .vscode-test
 *.vsix
 yarn-error.log
+.dccache

package.json

@@ -250,7 +250,7 @@
     "yalc": "^1.0.0-pre.44"
   },
   "dependencies": {
-    "@deepcode/tsc": "^2.0.0",
+    "@deepcode/tsc": "file:.yalc/@deepcode/tsc",
     "lodash": "^4.17.19",
     "open": "^7.2.1"
   }

src/deepcode/DeepCodeExtension.ts

@@ -1,11 +1,10 @@
 import * as vscode from 'vscode';
 import open from 'open';
-import { emitter } from '@deepcode/tsc';
 
 import { ExtensionInterface } from '../interfaces/DeepCodeInterfaces';
 import DeepCodeLib from './lib/modules/DeepCodeLib';
 import createFileWatcher from './lib/watchers/FilesWatcher';
-import { ISupportedFiles } from '@deepcode/tsc';
+import { emitter, ISupportedFiles } from '@deepcode/tsc';
 
 import {
   DEEPCODE_START_COMMAND,

src/deepcode/lib/analyzer/DeepCodeAnalyzer.ts

@@ -150,13 +150,6 @@ class DeepCodeAnalyzer implements AnalyzerInterface {
     this.setIssuesMarkersDecoration();
   }
 
-  public async configureIssuesDisplayBySeverity(severity: number, hide: boolean): Promise<void> {
-    this.SEVERITIES[severity].show = !hide;
-    if (Object.keys(this.analysisResults.suggestions).length) {
-      await this.createReviewResults();
-    }
-  }
-
   public async updateReviewResultsPositions(
     extension: ExtensionInterface,
     updatedFile: openedTextEditorType,

src/deepcode/lib/deepCodeProviders/hoverProvider/DeepCodeHoverProvider.ts

@@ -15,7 +15,7 @@ export class DisposableHoverProvider implements vscode.Disposable {
     this.hoverProvider = vscode.languages.registerHoverProvider(
       { scheme: "file", language: "*" },
       {
-        provideHover(document, position, _token) {
+        provideHover(document, position) {
           if (!deepcodeReview || !deepcodeReview.has(document.uri)) {
             return;
           }

src/deepcode/lib/modules/BundlesModule.ts

@@ -1,5 +1,4 @@
 import * as vscode from "vscode";
-import * as _ from "lodash";
 
 import { BundlesModuleInterface } from "../../../interfaces/DeepCodeInterfaces";
 

src/deepcode/lib/watchers/FilesWatcher.ts

@@ -10,19 +10,19 @@ export default function createFileWatcher(
   const globPattern: vscode.GlobPattern = `**/\{${getGlobPatterns(supportedFiles).join(',')}\}`;
   const watcher = vscode.workspace.createFileSystemWatcher(globPattern);
 
-  const updateFiles = (filePath: string, extension: ExtensionInterface): void => {
+  const updateFiles = (filePath: string): void => {
     extension.changedFiles.add(filePath);
     extension.startExtension(); // It's debounced, so not worries about concurrent calls
   };
 
   watcher.onDidChange((documentUri: vscode.Uri) => {
-    updateFiles(documentUri.fsPath, extension);
+    updateFiles(documentUri.fsPath);
   });
   watcher.onDidDelete(async (documentUri: vscode.Uri) => {
-    updateFiles(documentUri.fsPath, extension);
+    updateFiles(documentUri.fsPath);
   });
   watcher.onDidCreate((documentUri: vscode.Uri) => {
-    updateFiles(documentUri.fsPath, extension);
+    updateFiles(documentUri.fsPath);
   });
 
   return watcher;

src/interfaces/DeepCodeInterfaces.ts

@@ -122,6 +122,5 @@ export interface AnalyzerInterface {
   findSuggestion(suggestionName: string): ISuggestion | undefined;
   createReviewResults(): Promise<void>;
   updateReviewResultsPositions(extension: ExtensionInterface, updatedFile: openedTextEditorType): Promise<void>;
-  configureIssuesDisplayBySeverity(severity: number, hide: boolean): Promise<void>;
   setIssuesMarkersDecoration(editor: TextEditor | undefined): void;
 }

src/test/suite/extension.test.ts

@@ -11,8 +11,8 @@ import { ExtensionInterface } from "../../interfaces/DeepCodeInterfaces";
 
 const testToken = '23';
 const mockedTestFilesDirPath = __dirname.replace("out/test", "src/test");
-const mockedFolderPath = vscode.Uri.parse('scheme:' + nodePath.join(mockedTestFilesDirPath, '/../mocked_data'), true)
-  .fsPath;
+// const mockedFolderPath = vscode.Uri.parse('scheme:' + nodePath.join(mockedTestFilesDirPath, '/../mocked_data'), true)
+//   .fsPath;
 
 // pre test configuring extension
 const preTestConfigureExtension = () => {
@@ -29,9 +29,9 @@ const preTestConfigureExtension = () => {
   return testExtension;
 };
 
-const uri = vscode.Uri.file(nodePath.join(mockedTestFilesDirPath, '../mocked_data/sample_repository', 'main.js'));
+// const uri = vscode.Uri.file(nodePath.join(mockedTestFilesDirPath, '../mocked_data/sample_repository', 'main.js'));
 
-const testIgnoreComment = '  // deepcode ignore UseStrictEquality: <please specify a reason of ignoring this>\n';
+// const testIgnoreComment = '  // deepcode ignore UseStrictEquality: <please specify a reason of ignoring this>\n';
 
 suite("Deepcode Extension Tests", () => {
   let testExtension: ExtensionInterface;