Prevent failing to load desktop shortcuts from breaking package operations (fix #4328)

Author: marticliment

src/Directory.Build.props

@@ -5,7 +5,7 @@
         <TargetPlatformMinVersion>10.0.19041.0</TargetPlatformMinVersion>
         <!-- IF BUILD FAILS DUE TO MISSING Microsoft.Management.Deployment NAMESPACE,
             TOGGLE THE LAST NUMBER OF THE LINE BELOW 1 UNIT UP OR DOWN, AND REBUILD-->
-        <WindowsSdkPackageVersion>10.0.26100.57</WindowsSdkPackageVersion>
+        <WindowsSdkPackageVersion>10.0.26100.56</WindowsSdkPackageVersion>
 
         <SdkVersion>8.0.407</SdkVersion>
         <Authors>Martí Climent and the contributors</Authors>

src/UniGetUI.PackageEngine.PackageManagerClasses/Packages/Classes/DesktopShortcutsDatabase.cs

@@ -103,12 +103,21 @@ public static Status GetStatus(string shortcutPath)
     /// <returns>A list of desktop shortcut paths</returns>
     public static List<string> GetShortcutsOnDisk()
     {
-        List<string> shortcuts = [];
-        string UserDesktop = Environment.GetFolderPath(Environment.SpecialFolder.DesktopDirectory);
-        string CommonDesktop = Environment.GetFolderPath(Environment.SpecialFolder.CommonDesktopDirectory);
-        shortcuts.AddRange(Directory.EnumerateFiles(UserDesktop, "*.lnk"));
-        shortcuts.AddRange(Directory.EnumerateFiles(CommonDesktop, "*.lnk"));
-        return shortcuts;
+        try
+        {
+            List<string> shortcuts = [];
+            string UserDesktop = Environment.GetFolderPath(Environment.SpecialFolder.DesktopDirectory);
+            string CommonDesktop = Environment.GetFolderPath(Environment.SpecialFolder.CommonDesktopDirectory);
+            if (UserDesktop != "") shortcuts.AddRange(Directory.EnumerateFiles(UserDesktop, "*.lnk"));
+            if (CommonDesktop != "") shortcuts.AddRange(Directory.EnumerateFiles(CommonDesktop, "*.lnk"));
+            return shortcuts;
+        }
+        catch (Exception ex)
+        {
+            Logger.Error("Failed to load desktop shortcuts on disk");
+            Logger.Error(ex);
+            return [];
+        }
     }
 
     /// <summary>