ENG-1267: Separate duplicate node alert feature flag from suggestivemode (#898)

* ENG-1267: Separate duplicate node alert feature flag from suggestive mode

* Default duplicate node alert flag to false

* Disable duplicate node alert toggle when suggestive mode is off

* Add suggestive mode runtime guard and fix incidental blank line

* Remove legacy block sync props from duplicate node alert panel

Author: sid597

apps/roam/src/components/settings/AdminPanel.tsx

@@ -33,7 +33,11 @@ import { getFormattedConfigTree } from "~/utils/discourseConfigRef";
 import refreshConfigTree from "~/utils/refreshConfigTree";
 import createBlock from "roamjs-components/writes/createBlock";
 import deleteBlock from "roamjs-components/writes/deleteBlock";
-import { setFeatureFlag } from "~/components/settings/utils/accessors";
+import {
+  setFeatureFlag,
+  getFeatureFlag,
+} from "~/components/settings/utils/accessors";
+import { FeatureFlagPanel } from "./components/BlockPropSettingPanels";
 
 const NodeRow = ({ node }: { node: PConceptFull }) => {
   return (
@@ -346,6 +350,14 @@ const FeatureFlagsTab = (): React.ReactElement => {
         </p>
       </Alert>
 
+      <FeatureFlagPanel
+        title="Duplicate node alert"
+        description="Show possible duplicate nodes when viewing a discourse node page. Requires Suggestive mode to be enabled."
+        featureKey="Duplicate node alert enabled"
+        initialValue={getFeatureFlag("Duplicate node alert enabled")}
+        disabled={!suggestiveModeEnabled}
+      />
+
       <Button
         className="w-96"
         icon="send-message"

apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx

@@ -501,6 +501,7 @@ export const FeatureFlagPanel = ({
   description,
   featureKey,
   initialValue,
+  disabled,
   onBeforeEnable,
   onAfterChange,
   parentUid,
@@ -511,6 +512,7 @@ export const FeatureFlagPanel = ({
   description: string;
   featureKey: keyof FeatureFlags;
   initialValue?: boolean;
+  disabled?: boolean;
   onBeforeEnable?: () => Promise<boolean>;
   onAfterChange?: (checked: boolean) => void;
 } & RoamBlockSyncProps) => {
@@ -532,6 +534,7 @@ export const FeatureFlagPanel = ({
       settingKeys={[featureKey as string]}
       setter={featureFlagSetter}
       initialValue={initialValue}
+      disabled={disabled}
       onBeforeChange={handleBeforeChange}
       onChange={onAfterChange}
       parentUid={parentUid}

apps/roam/src/components/settings/utils/zodSchema.example.ts

@@ -89,11 +89,13 @@ const discourseNodeSettings: DiscourseNodeSettings = {
 const featureFlags: FeatureFlags = {
   "Enable left sidebar": true,
   "Suggestive mode enabled": true,
+  "Duplicate node alert enabled": true,
 };
 
 const defaultFeatureFlags: FeatureFlags = {
   "Enable left sidebar": false,
   "Suggestive mode enabled": false,
+  "Duplicate node alert enabled": false,
 };
 
 const exportSettings: ExportSettings = {

apps/roam/src/components/settings/utils/zodSchema.ts

@@ -156,6 +156,7 @@ export const DiscourseRelationSchema = z.object({
 export const FeatureFlagsSchema = z.object({
   "Enable left sidebar": z.boolean().default(false),
   "Suggestive mode enabled": z.boolean().default(false),
+  "Duplicate node alert enabled": z.boolean().default(false),
 });
 
 export const ExportSettingsSchema = z.object({

apps/roam/src/utils/initializeObserversAndListeners.ts

@@ -54,6 +54,7 @@ import { formatHexColor } from "~/components/settings/DiscourseNodeCanvasSetting
 import { getSetting } from "./extensionSettings";
 import { mountLeftSidebar } from "~/components/LeftSidebarView";
 import { getUidAndBooleanSetting } from "./getExportSettings";
+import { getFeatureFlag } from "~/components/settings/utils/accessors";
 import { getCleanTagText } from "~/components/settings/NodeConfig";
 import getPleasingColors from "@repo/utils/getPleasingColors";
 import { colord } from "colord";
@@ -116,7 +117,10 @@ export const initObservers = async ({
       const isDiscourseNode = node && node.backedBy !== "default";
       if (isDiscourseNode) {
         renderDiscourseContext({ h1, uid });
-        if (isSuggestiveModeEnabled) {
+        if (
+          isSuggestiveModeEnabled &&
+          getFeatureFlag("Duplicate node alert enabled")
+        ) {
           renderPossibleDuplicates(h1, title, node);
         }
         const linkedReferencesDiv = document.querySelector(