feat: improve never throw expandData error msg

david-roper · david-roper · commit 26f91efef7dd · 2025-09-30T13:21:21.000-04:00
diff --git a/apps/api/src/instrument-records/instrument-records.service.ts b/apps/api/src/instrument-records/instrument-records.service.ts
@@ -169,7 +169,6 @@ export class InstrumentRecordsService {
         instrument = (await this.instrumentsService.findById(record.instrumentId)) as ScalarInstrument;
         instruments.set(record.instrumentId, instrument);
       }
-      console.log();
       for (const [measureKey, measureValue] of Object.entries(record.computedMeasures)) {
         if (Array.isArray(measureValue)) {
           const objectRecord: RecordObject = {
@@ -185,7 +184,6 @@ export class InstrumentRecordsService {
           this.expandData(data, measureValue, instrument, objectRecord);
           continue;
         }
-
         let list;
         try {
           if (typeof measureValue === 'string') list = [JSON.parse(measureValue)];
@@ -471,7 +469,7 @@ export class InstrumentRecordsService {
       }
       return ok('Success');
     } else {
-      return err('Not an Array');
+      return err('Error interpretting array');
     }
   }
   private getInstrumentById(instrumentId: string) {

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,6 @@ export class InstrumentRecordsService {`
`169`	`169`	`instrument = (await this.instrumentsService.findById(record.instrumentId)) as ScalarInstrument;`
`170`	`170`	`instruments.set(record.instrumentId, instrument);`
`171`	`171`	`}`
`172`		`- console.log();`
`173`	`172`	`for (const [measureKey, measureValue] of Object.entries(record.computedMeasures)) {`
`174`	`173`	`if (Array.isArray(measureValue)) {`
`175`	`174`	`const objectRecord: RecordObject = {`
`@@ -185,7 +184,6 @@ export class InstrumentRecordsService {`
`185`	`184`	`this.expandData(data, measureValue, instrument, objectRecord);`
`186`	`185`	`continue;`
`187`	`186`	`}`
`188`		`-`
`189`	`187`	`let list;`
`190`	`188`	`try {`
`191`	`189`	`if (typeof measureValue === 'string') list = [JSON.parse(measureValue)];`
`@@ -471,7 +469,7 @@ export class InstrumentRecordsService {`
`471`	`469`	`}`
`472`	`470`	`return ok('Success');`
`473`	`471`	`} else {`
`474`		`- return err('Not an Array');`
	`472`	`+ return err('Error interpretting array');`
`475`	`473`	`}`
`476`	`474`	`}`
`477`	`475`	`private getInstrumentById(instrumentId: string) {`