chore: move global vars to top of file, specify wait time in error msg

Author: david-roper

testing/e2e/src/helpers/fixtures.ts

@@ -15,6 +15,9 @@ import type { NavigateVariadicArgs, ProjectAuth, ProjectMetadata, RouteTo } from
 
 type PageModels = typeof pageModels;
 
+const MAX_WAIT_MS = 30_000;
+const POLL_INTERVAL_MS = 200;
+
 type TestArgs = {
   getPageModel: <TKey extends Extract<keyof PageModels, RouteTo>>(
     key: TKey,
@@ -58,16 +61,17 @@ export const test = base.extend<TestArgs, WorkerArgs>({
       return use(async () => {
         const authStorageFile = getProjectMetadata('authStorageFile');
         // Wait for auth file to exist with timeout
-        const MAX_WAIT_MS = 30_000;
-        const POLL_INTERVAL_MS = 200;
+
         const maxAttempts = MAX_WAIT_MS / POLL_INTERVAL_MS;
         let attempts = 0;
         while (!fs.existsSync(authStorageFile) && attempts < maxAttempts) {
           await new Promise((resolve) => setTimeout(resolve, POLL_INTERVAL_MS));
           attempts++;
         }
         if (!fs.existsSync(authStorageFile)) {
-          throw new Error(`Cannot get project auth: storage file does not exist after waiting: ${authStorageFile}`);
+          throw new Error(
+            `Cannot get project auth: storage file does not exist after waiting 30000ms: ${authStorageFile}`
+          );
         }
         return JSON.parse(await fs.promises.readFile(authStorageFile, 'utf8')) as ProjectAuth;
       });