adjust metadata types

Author: joshunrau

testing/e2e/playwright.config.ts

@@ -7,7 +7,7 @@ import type { Project } from '@playwright/test';
 
 import { AUTH_STORAGE_DIR } from './src/helpers/constants';
 
-import type { BrowserName, ProjectMetadata } from './src/helpers/types';
+import type { BrowserTarget, ProjectMetadata } from './src/helpers/types';
 
 const apiPort = parseNumber(process.env.API_DEV_SERVER_PORT);
 const gatewayPort = parseNumber(process.env.GATEWAY_DEV_SERVER_PORT);
@@ -23,7 +23,7 @@ if (Number.isNaN(apiPort)) {
 
 const baseURL = `http://localhost:${webPort}`;
 
-const browsers: { target: BrowserName; use: Project['use'] }[] = [
+const browsers: { target: BrowserTarget; use: Project['use'] }[] = [
   { target: 'Desktop Chrome', use: { ...devices['Desktop Chrome'], channel: 'chromium', headless: true } },
   { target: 'Desktop Firefox', use: { ...devices['Desktop Firefox'], headless: true } }
 ] as const;
@@ -56,10 +56,8 @@ export default defineConfig({
           dependencies: i === 1 ? ['Global Setup'] : [`${i - 1}.x - ${browser.target}`],
           metadata: {
             authStorageFile: path.resolve(AUTH_STORAGE_DIR, `${browserId}.json`),
-            browser: {
-              id: browserId,
-              name: browser.target
-            }
+            browserId,
+            browserTarget: browser.target
           } satisfies ProjectMetadata,
           name: `${i}.x - ${browser.target}`,
           testMatch: `**/${i}.*.spec.ts`,

testing/e2e/src/helpers/types.ts

@@ -16,7 +16,7 @@ declare global {
   }
 }
 
-export type BrowserName = 'Desktop Chrome' | 'Desktop Firefox';
+export type BrowserTarget = 'Desktop Chrome' | 'Desktop Firefox';
 
 export type ExtractParams<TPath extends string> = Split<TPath, '/'>[number] extends infer TUnion
   ? TUnion extends `$${infer TParam}`
@@ -34,10 +34,8 @@ export type NavigateArgs<TPath extends RouteTo> = [to: TPath, ...NavigateVariadi
 
 export type ProjectMetadata = {
   authStorageFile: string;
-  browser: {
-    id: string;
-    name: BrowserName;
-  };
+  browserId: string;
+  browserTarget: BrowserTarget;
 };
 
 // export type RouteTo = import('../../../../apps/web/src/route-tree.ts').FileRouteTypes['to'];
@@ -51,5 +49,5 @@ export type RouteParams<TPath extends RouteTo> = {
   : never;
 
 export type TestDataMap<T> = {
-  [K in BrowserName]: T;
+  [K in BrowserTarget]: T;
 };