test: add content check for session form

Author: david-roper

testing/e2e/src/2.3-start-session.spec.ts

@@ -13,7 +13,8 @@ test.describe('start session', () => {
     await startSessionPage.sessionForm.waitFor({ state: 'visible' });
     const formType = startSessionPage.sessionForm.getByTestId('subjectIdentificationMethod-select-trigger');
     await formType.click();
-    await formType.getByRole('option', { name: 'Personal Information' }).click();
+
+    await startSessionPage.selectIdentificationMethod('PERSONAL_INFO');
 
     // await startSessionPage.selectIdentificationMethod('Personal Information')
     await expect(formType).toHaveText('Personal Information');

testing/e2e/src/pages/start-session.page.ts

@@ -4,22 +4,21 @@ import { AppPage } from './_app.page';
 
 export class StartSessionPage extends AppPage {
   readonly pageHeader: Locator;
+  readonly selectField: Locator;
   readonly sessionForm: Locator;
 
   constructor(page: Page) {
     super(page);
     this.pageHeader = page.getByTestId('page-header');
     this.sessionForm = page.getByTestId('start-session-form');
+    this.selectField = page.locator('[name="subjectIdentificationMethod"]');
   }
 
   async fillSessionForm(firstName: string) {
     await this.sessionForm.getByLabel('subjectId').fill(firstName);
   }
 
   async selectIdentificationMethod(methodName: string) {
-    const methodTrigger = this.sessionForm.getByRole('combobox', { name: /identification method/i });
-    await methodTrigger.click();
-    // The options are usually rendered in a portal at the end of the body
-    await methodTrigger.getByRole('option', { name: methodName }).click();
+    await this.selectField.selectOption(methodName);
   }
 }