feat: update return type in checkUsernameExists api call to boolean

Author: david-roper

apps/api/src/users/users.service.ts

@@ -17,7 +17,7 @@ export class UsersService {
     private readonly groupsService: GroupsService
   ) {}
 
-  async checkUsernameExists(username: string, { ability }: EntityOperationOptions = {}) {
+  async checkUsernameExists(username: string, { ability }: EntityOperationOptions = {}): Promise<{ success: boolean }> {
     const user = await this.userModel.findFirst({
       include: { groups: true },
       omit: {
@@ -26,9 +26,9 @@ export class UsersService {
       where: { AND: [accessibleQuery(ability, 'read', 'User'), { username }] }
     });
     if (!user) {
-      return false;
+      return { success: false };
     }
-    return user;
+    return { success: true };
   }
 
   async count(

apps/web/src/routes/_app/admin/users/create.tsx

@@ -22,15 +22,17 @@ const RouteComponent = () => {
 
   const handleSubmit = async (data: CreateUserData) => {
     // check if username exists
-    const existingUsername = await axios.get(`/v1/users/check-username/${encodeURIComponent(data.username)}`);
+    const existingUsername = await axios.get<{ success: boolean }>(
+      `/v1/users/check-username/${encodeURIComponent(data.username)}`
+    );
 
-    if (existingUsername.data !== false) {
+    if (existingUsername.data.success === true) {
       notification.addNotification({
         type: 'error',
         message: t('common.usernameExists')
       });
     } else {
-      createUserMutation.mutate({ data });
+      void createUserMutation.mutateAsync({ data });
 
       void navigate({ to: '..' });
     }