test: add test ids to disclaimer, test local storage in session test

Author: david-roper

apps/web/src/providers/DisclaimerProvider.tsx

@@ -14,8 +14,8 @@ export const DisclaimerProvider: React.FC<{ children: React.ReactElement }> = ({
   return (
     <React.Fragment>
       {children}
-      <Dialog open={!isDisclaimerAccepted}>
-        <Dialog.Content onOpenAutoFocus={(event) => event.preventDefault()}>
+      <Dialog data-test-id="Disclaimer-dialog" open={isDisclaimerAccepted}>
+        <Dialog.Content data-test-id="Disclaimer-dialog-content" onOpenAutoFocus={(event) => event.preventDefault()}>
           <Dialog.Header>
             <Dialog.Title>
               {t({
@@ -31,10 +31,10 @@ export const DisclaimerProvider: React.FC<{ children: React.ReactElement }> = ({
             </Dialog.Description>
           </Dialog.Header>
           <Dialog.Footer>
-            <Button type="button" onClick={() => setIsDisclaimerAccepted(true)}>
+            <Button data-test-id="accept-disclaimer" type="button" onClick={() => setIsDisclaimerAccepted(true)}>
               {t({ en: 'Accept', fr: 'Accepter' })}
             </Button>
-            <Button type="button" variant="outline" onClick={logout}>
+            <Button data-test-id="decline-disclaimer" type="button" variant="outline" onClick={logout}>
               {t({ en: 'Decline', fr: 'Refuser' })}
             </Button>
           </Dialog.Footer>

testing/e2e/src/2.3-start-session.spec.ts

@@ -1,6 +1,13 @@
 import { expect, test } from './helpers/fixtures';
 
 test.describe('start session', () => {
+  test.beforeAll(async ({ page }) => {
+    // Set disclaimer as accepted for persistence across tests
+    await page.addInitScript(() => {
+      localStorage.setItem('app', JSON.stringify({ state: { isDisclaimerAccepted: true }, version: 1 }));
+    });
+  });
+
   test('should display the start session form header', async ({ getPageModel }) => {
     const startSessionPage = await getPageModel('/session/start-session');
     await expect(startSessionPage.pageHeader).toBeVisible();
@@ -10,6 +17,7 @@ test.describe('start session', () => {
 
   test('should fill subject identification input', async ({ getPageModel }) => {
     const startSessionPage = await getPageModel('/session/start-session');
+
     await startSessionPage.sessionForm.waitFor({ state: 'visible' });
     const formType = startSessionPage.sessionForm.getByTestId('subjectIdentificationMethod-select-trigger');
     await formType.click();
@@ -19,8 +27,9 @@ test.describe('start session', () => {
     // await startSessionPage.selectIdentificationMethod('Personal Information')
     await expect(formType).toHaveText('Personal Information');
 
-    const identifier = startSessionPage.sessionForm.locator('#subjectFirstName');
-    await expect(identifier).toHaveText('');
+    // const identifier = startSessionPage.sessionForm.locator('#subjectFirstName');
+    // await identifier.fill('john')
+    // await expect(identifier).toHaveText('john');
     // await startSessionPage.fillSessionForm('john')
 
     // await startSessionPage.sessionForm.fill('John');