fix: add try catch for errors for template csv download

Author: david-roper

apps/web/src/features/upload/pages/UploadPage.tsx

@@ -27,8 +27,18 @@ export const UploadPage = () => {
   const { t } = useTranslation();
 
   const handleTemplateDownload = () => {
-    const { content, fileName } = createUploadTemplateCSV(instrument!);
-    void download(fileName, content);
+    try {
+      const { content, fileName } = createUploadTemplateCSV(instrument!);
+      void download(fileName, content);
+    } catch (error) {
+      addNotification({
+        message: t({
+          en: 'Error occurred downloading sample template',
+          fr: "Un occurence d'un erreur quand le csv document est telecharger"
+        }),
+        type: 'error'
+      });
+    }
   };
 
   const handleInstrumentCSV = async () => {

apps/web/src/features/upload/utils.ts

@@ -411,40 +411,44 @@ function generateSampleData({
 
 export function createUploadTemplateCSV(instrument: AnyUnilingualFormInstrument) {
   // TODO - type validationSchema as object
-  const instrumentSchema = instrument.validationSchema as z.AnyZodObject;
+  try {
+    const instrumentSchema = instrument.validationSchema as z.AnyZodObject;
 
-  const instrumentSchemaDef: unknown = instrument.validationSchema._def;
+    const instrumentSchemaDef: unknown = instrument.validationSchema._def;
 
-  let shape: { [key: string]: z.ZodTypeAny } = {};
+    let shape: { [key: string]: z.ZodTypeAny } = {};
 
-  if (isZodTypeDef(instrumentSchemaDef) && isZodEffectsDef(instrumentSchemaDef)) {
-    const innerSchema: unknown = instrumentSchemaDef.schema._def;
-    if (isZodTypeDef(innerSchema) && isZodObjectDef(innerSchema)) {
-      shape = innerSchema.shape() as { [key: string]: z.ZodTypeAny };
+    if (isZodTypeDef(instrumentSchemaDef) && isZodEffectsDef(instrumentSchemaDef)) {
+      const innerSchema: unknown = instrumentSchemaDef.schema._def;
+      if (isZodTypeDef(innerSchema) && isZodObjectDef(innerSchema)) {
+        shape = innerSchema.shape() as { [key: string]: z.ZodTypeAny };
+      }
+    } else {
+      shape = instrumentSchema.shape as { [key: string]: z.ZodTypeAny };
     }
-  } else {
-    shape = instrumentSchema.shape as { [key: string]: z.ZodTypeAny };
-  }
 
-  const columnNames = Object.keys(shape);
+    const columnNames = Object.keys(shape);
 
-  const csvColumns = INTERNAL_HEADERS.concat(columnNames);
+    const csvColumns = INTERNAL_HEADERS.concat(columnNames);
 
-  const sampleData = [...INTERNAL_HEADERS_SAMPLE_DATA];
-  for (const col of columnNames) {
-    const typeNameResult = getZodTypeName(shape[col]!);
-    if (!typeNameResult.success) {
-      throw new Error(typeNameResult.message);
+    const sampleData = [...INTERNAL_HEADERS_SAMPLE_DATA];
+    for (const col of columnNames) {
+      const typeNameResult = getZodTypeName(shape[col]!);
+      if (!typeNameResult.success) {
+        throw new Error(typeNameResult.message);
+      }
+      sampleData.push(generateSampleData(typeNameResult));
     }
-    sampleData.push(generateSampleData(typeNameResult));
-  }
 
-  unparse([csvColumns, sampleData]);
+    unparse([csvColumns, sampleData]);
 
-  return {
-    content: unparse([csvColumns, sampleData]),
-    fileName: `${instrument.internal.name}_${instrument.internal.edition}_template.csv`
-  };
+    return {
+      content: unparse([csvColumns, sampleData]),
+      fileName: `${instrument.internal.name}_${instrument.internal.edition}_template.csv`
+    };
+  } catch {
+    throw new Error('Error generating Sample CSV template');
+  }
 }
 
 export async function processInstrumentCSV(