refactor test

Author: joshunrau

testing/e2e/src/global/global.setup.spec.ts

@@ -1,33 +1,7 @@
-/* eslint-disable @typescript-eslint/no-namespace */
-/* eslint-disable @typescript-eslint/consistent-type-definitions */
-
 import type { LoginCredentials } from '@opendatacapture/schemas/auth';
-import type { InitAppOptions } from '@opendatacapture/schemas/setup';
 import { expect, test } from '@playwright/test';
 
-const initOptions = {
-  admin: {
-    firstName: 'Jane',
-    lastName: 'Doe',
-    password: 'DataCapture2025',
-    username: 'admin'
-  },
-  dummySubjectCount: 10,
-  enableExperimentalFeatures: false,
-  initDemo: true,
-  recordsPerSubject: 10
-} satisfies InitAppOptions;
-
-declare global {
-  namespace NodeJS {
-    interface ProcessEnv {
-      ADMIN_ACCESS_TOKEN: string;
-      ADMIN_PASSWORD: string;
-      ADMIN_USERNAME: string;
-      GLOBAL_SETUP_COMPLETE?: '1';
-    }
-  }
-}
+import { initAppOptions } from '../helpers/data';
 
 test.skip(() => process.env.GLOBAL_SETUP_COMPLETE === '1');
 
@@ -42,14 +16,14 @@ test.describe.serial(() => {
       await page.goto('/setup');
       await expect(page).toHaveURL('/setup');
       const setupForm = page.locator('form[data-cy="setup-form"]');
-      await setupForm.locator('input[name="firstName"]').fill(initOptions.admin.firstName);
-      await setupForm.locator('input[name="lastName"]').fill(initOptions.admin.lastName);
-      await setupForm.locator('input[name="username"]').fill(initOptions.admin.username);
-      await setupForm.locator('input[name="password"]').fill(initOptions.admin.password);
-      await setupForm.locator('input[name="confirmPassword"]').fill(initOptions.admin.password);
+      await setupForm.locator('input[name="firstName"]').fill(initAppOptions.admin.firstName);
+      await setupForm.locator('input[name="lastName"]').fill(initAppOptions.admin.lastName);
+      await setupForm.locator('input[name="username"]').fill(initAppOptions.admin.username);
+      await setupForm.locator('input[name="password"]').fill(initAppOptions.admin.password);
+      await setupForm.locator('input[name="confirmPassword"]').fill(initAppOptions.admin.password);
       await setupForm.locator('#initDemo-true').click();
-      await setupForm.locator('input[name="dummySubjectCount"]').fill(initOptions.dummySubjectCount.toString());
-      await setupForm.locator('input[name="recordsPerSubject"]').fill(initOptions.recordsPerSubject.toString());
+      await setupForm.locator('input[name="dummySubjectCount"]').fill(initAppOptions.dummySubjectCount.toString());
+      await setupForm.locator('input[name="recordsPerSubject"]').fill(initAppOptions.recordsPerSubject.toString());
       await setupForm.getByLabel('Submit').click();
       await expect(page).toHaveURL('/dashboard');
     });
@@ -61,7 +35,7 @@ test.describe.serial(() => {
   });
   test.describe.serial('auth', () => {
     test('login', async ({ request }) => {
-      const { password, username } = initOptions.admin;
+      const { password, username } = initAppOptions.admin;
       const response = await request.post('/api/v1/auth/login', {
         data: { password, username } satisfies LoginCredentials
       });

testing/e2e/src/helpers/data.ts

@@ -0,0 +1,14 @@
+import type { InitAppOptions } from '@opendatacapture/schemas/setup';
+
+export const initAppOptions = {
+  admin: {
+    firstName: 'Jane',
+    lastName: 'Doe',
+    password: 'DataCapture2025',
+    username: 'admin'
+  },
+  dummySubjectCount: 10,
+  enableExperimentalFeatures: false,
+  initDemo: true,
+  recordsPerSubject: 10
+} satisfies InitAppOptions;

testing/e2e/src/helpers/types.ts

@@ -1,3 +1,16 @@
+/* eslint-disable @typescript-eslint/no-namespace */
+/* eslint-disable @typescript-eslint/consistent-type-definitions */
+
+declare global {
+  namespace NodeJS {
+    interface ProcessEnv {
+      ADMIN_ACCESS_TOKEN: string;
+      ADMIN_PASSWORD: string;
+      ADMIN_USERNAME: string;
+      GLOBAL_SETUP_COMPLETE?: '1';
+    }
+  }
+}
 export type BrowserTarget = 'Desktop Chrome' | 'Desktop Firefox' | 'Desktop Safari';
 
 export type ProjectMetadata = {