chore: linting fixes

Author: david-roper

testing/e2e/src/pages/start-session.page.ts

@@ -16,20 +16,15 @@ export class StartSessionPage extends AppPage {
     this.successMessage = page.getByRole('heading', { name: 'Session Successfully Started' });
   }
 
-  async fillSessionForm(firstName: string, lastName: string, sex: string) {
-    // Wait for the subjectFirstName field to appear after selecting PERSONAL_INFO
-    const firstNameField = this.sessionForm.locator('[name="subjectFirstName"]');
-    const lastNameField = this.sessionForm.locator('[name="subjectLastName"]');
+  async fillCustomIdentifier(customIdentifier: string, sex: string) {
+    const subjectIdField = this.sessionForm.locator('[name="subjectId"]');
     const dateOfBirthField = this.sessionForm.locator('[name="subjectDateOfBirth"]');
     const sexSelector = this.sessionForm.locator('[name="subjectSex"]');
     const sessionTypeSelector = this.sessionForm.locator('[name="sessionType"]');
     const sessionDate = this.sessionForm.locator('[name="sessionDate"]');
 
-    await firstNameField.waitFor({ state: 'visible' });
-    await firstNameField.fill(firstName);
-
-    await lastNameField.waitFor({ state: 'visible' });
-    await lastNameField.fill(lastName);
+    await subjectIdField.waitFor({ state: 'visible' });
+    await subjectIdField.fill(customIdentifier);
 
     await dateOfBirthField.waitFor({ state: 'visible' });
     await dateOfBirthField.fill('1990-01-01');
@@ -42,15 +37,20 @@ export class StartSessionPage extends AppPage {
     await sessionDate.fill('2026-01-01');
   }
 
-  async fillCustomIdentifier(customIdentifier: string, sex: string) {
-    const subjectIdField = this.sessionForm.locator('[name="subjectId"]');
+  async fillSessionForm(firstName: string, lastName: string, sex: string) {
+    // Wait for the subjectFirstName field to appear after selecting PERSONAL_INFO
+    const firstNameField = this.sessionForm.locator('[name="subjectFirstName"]');
+    const lastNameField = this.sessionForm.locator('[name="subjectLastName"]');
     const dateOfBirthField = this.sessionForm.locator('[name="subjectDateOfBirth"]');
     const sexSelector = this.sessionForm.locator('[name="subjectSex"]');
     const sessionTypeSelector = this.sessionForm.locator('[name="sessionType"]');
     const sessionDate = this.sessionForm.locator('[name="sessionDate"]');
 
-    await subjectIdField.waitFor({ state: 'visible' });
-    await subjectIdField.fill(customIdentifier);
+    await firstNameField.waitFor({ state: 'visible' });
+    await firstNameField.fill(firstName);
+
+    await lastNameField.waitFor({ state: 'visible' });
+    await lastNameField.fill(lastName);
 
     await dateOfBirthField.waitFor({ state: 'visible' });
     await dateOfBirthField.fill('1990-01-01');