New loan function complete

Author: DylanW01

src/main/java/EJB/LoanOracleBean.java

@@ -19,34 +19,27 @@ public class LoanOracleBean {
     @EJB
     OracleClientProviderBean oracleClientProviderBean;
 
-    public void createLoan(loanModel loan) {
+   public void createLoan(loanModel loan) {
         Date currentDate = new Date();
         Calendar calendar = Calendar.getInstance();
         calendar.setTime(currentDate);
-
         calendar.add(Calendar.DAY_OF_MONTH, 14);
-
         Date dateAfterTwoWeeks = calendar.getTime();
-        Date test = new java.sql.Date(dateAfterTwoWeeks.getTime());
 
-        String insertLoan = "INSERT INTO loans"
-                + "(book_id, user_id, return_by, returned)" + "VALUES ("
-                + "'" + loan.getBookId() + "',"
-                + "'" + loan.getUserId() + "',"
-                + "'" + test + "',"
-                + "0,";
+        String insertLoan = "INSERT INTO loans (book_id, user_id, return_by, returned) VALUES (?, ?, ?, 0)";
 
-        Statement stmt = null;
-        try {
-            Connection con = oracleClientProviderBean.getOracleClient();
-            stmt = con.createStatement();
+        try (Connection con = oracleClientProviderBean.getOracleClient();
+             PreparedStatement preparedStatement = con.prepareStatement(insertLoan)) {
 
-            System.out.println(insertLoan);
+            preparedStatement.setLong(1, loan.getBookId());
+            preparedStatement.setLong(2, loan.getUserId());
+            preparedStatement.setDate(3, new java.sql.Date(dateAfterTwoWeeks.getTime()));
 
-            stmt.executeUpdate(insertLoan);
+            System.out.println(preparedStatement); // For debugging purposes
 
-            stmt.close();
-        } catch(SQLException e) {
+            preparedStatement.executeUpdate();
+
+        } catch (SQLException e) {
             e.printStackTrace();
         }
     }

src/main/java/Loans.java

@@ -43,12 +43,10 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t
 
     @Override
     protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
+        response.setContentType("text/html");
         PrintWriter out = response.getWriter();
-
         loanModel loan = new loanModel();
-        out.print("Creating Loan");
-        out.print(request.getParameter("users"));
-        out.print(request.getParameter("books"));
+        out.println("Loan Created. <a href=\"http://localhost:8080/OracleSQL-Library-1.0-SNAPSHOT/newloan.jsp\">Click Here</a> to go back");
         loan.setUserId((long) Integer.parseInt(request.getParameter("users")));
         loan.setBookId((long) Integer.parseInt(request.getParameter("books")));
         loanBean.createLoan(loan);