make path resolve strict for windows

Author: SarahAlidoost

PyStemmusScope/utils.py

@@ -1,3 +1,4 @@
+import os
 from pathlib import Path
 import numpy as np
 
@@ -25,10 +26,13 @@ def convert_to_lsm_coordinates(lat, lon):
     return np.round(lat).astype(int), np.round(lon).astype(int)
 
 
+def os_name():
+    return os.name
+
+
 def to_absolute_path(
     input_path: str,
     parent: Path = None,
-    must_exist: bool = False,
     must_be_in_parent=True,
 ) -> Path:
     """Parse input string as :py:class:`pathlib.Path` object.
@@ -43,6 +47,9 @@ def to_absolute_path(
     Returns:
         The input path that is an absolute path and a :py:class:`pathlib.Path` object.
     """
+    # care for windows, see issue 22
+    must_exist = os_name() == 'nt'
+
     pathlike = Path(input_path)
     if parent:
         pathlike = parent.joinpath(pathlike)

tests/test_utils.py

@@ -1,22 +1,25 @@
 
 from pathlib import Path
+from unittest.mock import patch
 
 import pytest
 from PyStemmusScope import utils
 
 # TODO add test for convert_to_lsm_coordinates
 
+
 def test_to_absolute_path():
     input_path = "~/nonexistent_file.txt"
     parsed = utils.to_absolute_path(input_path)
     expected = Path.home() / "nonexistent_file.txt"
     assert parsed == expected
 
-
-def test_to_absolute_path_must_exist():
+@patch("PyStemmusScope.utils.os_name")
+def test_to_absolute_path_must_exist(mocked_osname):
     input_path = "~/nonexistent_file.txt"
+    mocked_osname.return_value = "nt"
     with pytest.raises(FileNotFoundError):
-        utils.to_absolute_path(input_path, must_exist=True)
+        utils.to_absolute_path(input_path)
 
 
 def test_to_absolute_path_with_absolute_input_and_parent(tmp_path):
@@ -33,16 +36,24 @@ def test_to_absolute_path_with_relative_input_and_parent(tmp_path):
 
 
 def test_to_absolute_path_with_relative_input_and_no_parent():
-    input_path = "nonexistent_file.txt"
+    input_path = "./input_dir"
+
+    # care for windows, see issue 22
+    Path(input_path).mkdir(exist_ok=True)
+
     parsed = utils.to_absolute_path(input_path)
-    expected = Path.cwd() / "nonexistent_file.txt"
+    expected = Path.cwd() / "input_dir"
     assert parsed == expected
 
 
 def test_to_absolute_path_with_relative_input_and_relative_parent():
-    input_path = "nonexistent_file.txt"
+    input_path = "./input_dir"
+
+    # care for windows, see issue 22
+    Path(input_path).mkdir(exist_ok=True)
+
     parsed = utils.to_absolute_path(input_path, parent=Path("."))
-    expected = Path.cwd() / "nonexistent_file.txt"
+    expected = Path.cwd() / "input_dir"
     assert parsed == expected