Add fixture for mocking iCRSSession

Issues:
Fixes #<issueid>

Problem:

Analysis:

Tests:

Author: zancas

conftest.py

@@ -14,8 +14,11 @@
 #
 
 from f5.bigip import BigIP
+import mock
 import pytest
 
+from icontrol.session import iControlRESTSession
+
 
 def pytest_addoption(parser):
     parser.addoption("--bigip", action="store",
@@ -33,6 +36,19 @@ def pytest_addoption(parser):
                      default='11.6.0')
 
 
+@pytest.fixture
+def fakeicontrolsession(monkeypatch):
+    class Response(object):
+        def json(self):
+            return {'selfLink': 'https://localhost/mgmt/tm/sys?ver=11.6.0'}
+    fakesessionclass = mock.create_autospec(iControlRESTSession, spec_set=True)
+    fakesessioninstance =\
+        mock.create_autospec(iControlRESTSession('A', 'B'), spec_set=True)
+    fakesessioninstance.get = mock.MagicMock(return_value=Response())
+    fakesessionclass.return_value = fakesessioninstance
+    monkeypatch.setattr('f5.bigip.iControlRESTSession', fakesessionclass)
+
+
 @pytest.fixture
 def opt_bigip(request):
     return request.config.getoption("--bigip")

f5/bigip/cm/autodeploy/test/test_software_image_uploads.py

@@ -24,7 +24,7 @@
 CHUNKSIZE = 20
 
 
-def test_software_image_uploads_80a(tmpdir):
+def test_software_image_uploads_80a(tmpdir, fakeicontrolsession):
     filepath = tmpdir.mkdir('testdir').join('eightya.iso')
     filepath.write(80*'a')
     mr = ManagementRoot('FAKENETLOC', 'FAKENAME', 'FAKEPASSWORD')
@@ -37,7 +37,7 @@ def test_software_image_uploads_80a(tmpdir):
         assert d == 'a'*CHUNKSIZE
 
 
-def test_software_image_uploads_70a(tmpdir):
+def test_software_image_uploads_70a(tmpdir, fakeicontrolsession):
     filepath = tmpdir.mkdir('testdir').join('seventya.iso')
     filepath.write(70*'a')
     mr = ManagementRoot('FAKENETLOC', 'FAKENAME', 'FAKEPASSWORD')
@@ -53,7 +53,7 @@ def test_software_image_uploads_70a(tmpdir):
     assert 10*'a' == lchunk
 
 
-def test_non_ISO_extension(tmpdir):
+def test_non_ISO_extension(tmpdir, fakeicontrolsession):
     filepath = tmpdir.mkdir('testdir').join('wrong.name')
     mr = ManagementRoot('FAKENETLOC', 'FAKENAME', 'FAKEPASSWORD')
     sius = mr.cm.autodeploy.software_image_uploads

f5/bigip/shared/test/test_file_uploads.py

@@ -22,7 +22,7 @@
     FileMustNotHaveDotISOExtension
 
 
-def test_file_upload_80a(tmpdir):
+def test_file_upload_80a(tmpdir, fakeicontrolsession):
     filepath = tmpdir.mkdir('testdir').join('eightya.txt')
     filepath.write(80*'a')
     mr = ManagementRoot('FAKENETLOC', 'FAKENAME', 'FAKEPASSWORD')
@@ -35,7 +35,7 @@ def test_file_upload_80a(tmpdir):
         assert d == 'aaaaaaaaaaaaaaaaaaaa'
 
 
-def test_file_upload_70a(tmpdir):
+def test_file_upload_70a(tmpdir, fakeicontrolsession):
     filepath = tmpdir.mkdir('testdir').join('seventya.txt')
     filepath.write(70*'a')
     mr = ManagementRoot('FAKENETLOC', 'FAKENAME', 'FAKEPASSWORD')
@@ -51,7 +51,7 @@ def test_file_upload_70a(tmpdir):
     assert 10*'a' == lchunk
 
 
-def test_ISO_extension(tmpdir):
+def test_ISO_extension(tmpdir, fakeicontrolsession):
     filepath = tmpdir.mkdir('testdir').join('wrongname.iso')
     filepath.write('fake')
     mr = ManagementRoot('FAKENETLOC', 'FAKENAME', 'FAKEPASSWORD')
@@ -61,7 +61,7 @@ def test_ISO_extension(tmpdir):
     assert EIO.value.message == 'wrongname.iso'
 
 
-def test_stringio_upload_80a(tmpdir):
+def test_stringio_upload_80a(tmpdir, fakeicontrolsession):
     sio = StringIO(80*'a')
     mr = ManagementRoot('FAKENETLOC', 'FAKENAME', 'FAKEPASSWORD')
     mr._meta_data['icr_session'] = mock.MagicMock()
@@ -73,7 +73,7 @@ def test_stringio_upload_80a(tmpdir):
         assert d == 'aaaaaaaaaaaaaaaaaaaa'
 
 
-def test_stringio_upload_70a(tmpdir):
+def test_stringio_upload_70a(tmpdir, fakeicontrolsession):
     sio = StringIO(70*'a')
     mr = ManagementRoot('FAKENETLOC', 'FAKENAME', 'FAKEPASSWORD')
     mr._meta_data['icr_session'] = mock.MagicMock()
@@ -87,7 +87,7 @@ def test_stringio_upload_70a(tmpdir):
     assert 10*'a' == lchunk
 
 
-def test_bytes_upload_80a(tmpdir):
+def test_bytes_upload_80a(tmpdir, fakeicontrolsession):
     bytestring80a = 80*'a'
     mr = ManagementRoot('FAKENETLOC', 'FAKENAME', 'FAKEPASSWORD')
     mr._meta_data['icr_session'] = mock.MagicMock()
@@ -99,7 +99,7 @@ def test_bytes_upload_80a(tmpdir):
         assert d == 'aaaaaaaaaaaaaaaaaaaa'
 
 
-def test_bytes_upload_70a(tmpdir):
+def test_bytes_upload_70a(tmpdir, fakeicontrolsession):
     bytestring70a = 70*'a'
     mr = ManagementRoot('FAKENETLOC', 'FAKENAME', 'FAKEPASSWORD')
     mr._meta_data['icr_session'] = mock.MagicMock()

f5/bigip/test/test___init__.py

@@ -26,14 +26,14 @@
 
 
 @pytest.fixture
-def FakeBigIP():
+def FakeBigIP(fakeicontrolsession):
     FBIP = BigIP('FakeHostName', 'admin', 'admin')
     FBIP.icontrol = mock.MagicMock()
     return FBIP
 
 
 @pytest.fixture
-def FakeBigIPWithPort():
+def FakeBigIPWithPort(fakeicontrolsession):
     FBIP = BigIP('FakeHostName', 'admin', 'admin', port='10443')
     FBIP.icontrol = mock.MagicMock()
     return FBIP

f5/bigip/tm/auth/test/test_user.py

@@ -29,7 +29,7 @@ def FakeUser():
 
 
 class TestCreate(object):
-    def test_create_two(self):
+    def test_create_two(self, fakeicontrolsession):
         b = BigIP('localhost', 'admin', 'admin')
         n1 = b.auth.users.user
         n2 = b.auth.users.user

f5/bigip/tm/cm/test/test___init__.py

@@ -20,7 +20,7 @@
 
 
 @pytest.fixture
-def FakeiControl():
+def FakeiControl(fakeicontrolsession):
     bigip = BigIP('host', 'fake_admin', 'fake_admin')
     mock_session = mock.MagicMock()
     mock_session.post.return_value.json.return_value = {}

f5/bigip/tm/ltm/test/test_nat.py

@@ -29,7 +29,7 @@ def FakeNat():
 
 
 class TestCreate(object):
-    def test_create_two(self):
+    def test_create_two(self, fakeicontrolsession):
         b = BigIP('192.168.1.1', 'admin', 'admin')
         n1 = b.ltm.nats.nat
         n2 = b.ltm.nats.nat

f5/bigip/tm/ltm/test/test_rule.py

@@ -29,7 +29,7 @@ def FakeRule():
 
 
 class TestCreate(object):
-    def test_create_two(self):
+    def test_create_two(self, fakeicontrolsession):
         b = BigIP('192.168.1.1', 'admin', 'admin')
         r1 = b.ltm.rules.rule
         r2 = b.ltm.rules.rule

f5/bigip/tm/sys/test/test_db.py

@@ -22,12 +22,15 @@
 @pytest.fixture
 def fake_dbs():
     fake_sys = mock.MagicMock()
-    return Dbs(fake_sys)
+    dbs = Dbs(fake_sys)
+    dbs._meta_data['bigip'].tmos_version = '11.6.0'
+    return dbs
 
 
 class TestDb(object):
     def test_create_raises(self):
         dbs = fake_dbs()
+        print(dbs.raw)
         db = dbs.db
         with pytest.raises(UnsupportedOperation):
             db.create()

f5/bigip/tm/sys/test/test_folder.py

@@ -23,7 +23,9 @@
 @pytest.fixture
 def FakeFolders():
     fake_sys = mock.MagicMock()
-    return Folders(fake_sys)
+    folders = Folders(fake_sys)
+    folders._meta_data['bigip'].tmos_version = '11.6.0'
+    return folders
 
 
 class TestFolder(object):