Add Stats attribute to https profile endpoint (#1441)

Add HostInfo endpoint
Add Disk endpoint
Add corresponding unit and functional tests
Corrected flake8 errors

Author: wojtek0806

f5/bigip/tm/ltm/profile.py

@@ -30,6 +30,7 @@
 from f5.bigip.resource import Collection
 from f5.bigip.resource import OrganizingCollection
 from f5.bigip.resource import Resource
+from f5.bigip.resource import Stats
 from f5.sdk_exception import MissingUpdateParameter
 from f5.sdk_exception import UnsupportedOperation
 
@@ -443,7 +444,7 @@ class Https(Collection):
     """BIG-IP® Http profile collection."""
     def __init__(self, profile):
         super(Https, self).__init__(profile)
-        self._meta_data['allowed_lazy_attributes'] = [Http]
+        self._meta_data['allowed_lazy_attributes'] = [Http, Stats]
         self._meta_data['attribute_registry'] = \
             {'tm:ltm:profile:http:httpstate': Http}
 

f5/bigip/tm/ltm/test/functional/test_lsnpool.py

@@ -125,6 +125,7 @@ def test_create_with_logProfile(self, request, mgmt_root):
             name='lsnlogpool1')
 
         setup_create_test(request, mgmt_root, 'lsnpool1')
+
         default_pub = '/Common/local-db-publisher'
         pool1 = mgmt_root.tm.ltm.lsn_pools.lsn_pool.create(name='lsnpool1',
                                                            logProfile=logprofile1.name,

f5/bigip/tm/ltm/test/functional/test_profile.py

@@ -26,10 +26,11 @@
 
 # Helper class to limit code repetition
 class HelperTest(object):
-    def __init__(self, collection_name):
+    def __init__(self, collection_name, **kwargs):
         self.partition = 'Common'
         self.lowered = collection_name.lower()
         self.test_name = 'test.' + self.urielementname()
+        self.stats = kwargs.pop('stats', False)
 
     def urielementname(self):
         if self.lowered[-2:] == '_s':
@@ -479,7 +480,6 @@ def test_MCURDL(self, request, mgmt_root):
         http = HelperTest('Https')
         http.test_MCURDL(request, mgmt_root)
 
-
 # End HTTP tests
 
 # Begin HTTP Compression tests

f5/bigip/tm/sys/__init__.py

@@ -35,12 +35,14 @@
 from f5.bigip.tm.sys.crypto import Crypto
 from f5.bigip.tm.sys.daemon_log_settings import Daemon_Log_Settings
 from f5.bigip.tm.sys.db import Dbs
+from f5.bigip.tm.sys.disk import Disk
 from f5.bigip.tm.sys.dns import Dns
 from f5.bigip.tm.sys.failover import Failover
 from f5.bigip.tm.sys.feature_module import Feature_Module
 from f5.bigip.tm.sys.file import File
 from f5.bigip.tm.sys.folder import Folders
 from f5.bigip.tm.sys.global_settings import Global_Settings
+from f5.bigip.tm.sys.host_info import Host_Info
 from f5.bigip.tm.sys.httpd import Httpd
 from f5.bigip.tm.sys.icall import Icall
 from f5.bigip.tm.sys.license import License
@@ -78,10 +80,12 @@ def __init__(self, tm):
             File,
             Folders,
             Global_Settings,
+            Host_Info,
             Httpd,
             Icall,
             License,
             Log_Config,
+            Disk,
             Management_Ips,
             Management_Routes,
             Ntp,

f5/bigip/tm/sys/disk.py

@@ -0,0 +1,104 @@
+# coding=utf-8
+#
+# Copyright 2016 F5 Networks Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""BIG-IP® system disk module.
+
+REST URI
+    ``http://localhost/mgmt/tm/sys/disk/*``
+
+GUI Path
+    ``System --> Disk Management --> *``
+
+REST Kind
+    ``tm:sys:disk:*``
+"""
+
+from f5.bigip.resource import Collection
+from f5.bigip.resource import OrganizingCollection
+from f5.bigip.resource import Resource
+from f5.sdk_exception import UnsupportedMethod
+
+
+class Disk(OrganizingCollection):
+    def __init__(self, sys):
+        super(Disk, self).__init__(sys)
+        self._meta_data['allowed_lazy_attributes'] = [
+            Logical_Disks,
+        ]
+
+
+class Directory(object):
+    """Directory stats class, has 2 endpoints producing the same output:
+
+    "https://localhost/mgmt/tm/sys/disk/directory" and
+
+    "https://localhost/mgmt/tm/sys/disk/directory/stats/"
+
+    This will require careful thought on the implementation. This is a placeholder for future
+    """
+    pass
+
+
+class Application_Volume(object):
+    """Placeholder for another endpoint"""
+    pass
+
+
+class Logical_Disks(Collection):
+    """BIG-IP® system logical disk collection"""
+    def __init__(self, sys):
+        super(Logical_Disks, self).__init__(sys)
+        self._meta_data['object_has_stats'] = False
+        self._meta_data['attribute_registry'] = \
+            {'tm:sys:disk:logical-disk:logical-diskstate': Logical_Disk}
+        self._meta_data['allowed_lazy_attributes'] = [Logical_Disk]
+
+
+class Logical_Disk(Resource):
+    """BIG-IP® system logical disk unnamed resource"""
+    def __init__(self, logical_disks):
+        super(Logical_Disk, self).__init__(logical_disks)
+        self._meta_data['required_json_kind'] =\
+            'tm:sys:disk:logical-disk:logical-diskstate'
+
+    def update(self, **kwargs):
+        """Update is not supported for logical disk.
+
+        :raises: :exc:`~f5.BIG-IP.resource.UnsupportedMethod`
+        """
+        raise UnsupportedMethod("{0} does not support the update method, only load and refresh".format(self.__class__.__name__))
+
+    def create(self, **kwargs):
+        """Create is not supported for logical disk.
+
+        :raises: :exc:`~f5.BIG-IP.resource.UnsupportedMethod`
+        """
+        raise UnsupportedMethod("{0} does not support the create method, only load and refresh".format(self.__class__.__name__))
+
+    def modify(self, **kwargs):
+        """Modify is not supported for logical disk.
+
+        :raises: :exc:`~f5.BIG-IP.resource.UnsupportedMethod`
+        """
+        raise UnsupportedMethod("{0} does not support the modify method, only load and refresh".format(self.__class__.__name__))
+
+    def delete(self, **kwargs):
+        """Delete is not supported for logical disk.
+
+        :raises: :exc:`~f5.BIG-IP.resource.UnsupportedMethod``
+        """
+        raise UnsupportedMethod("{0} does not support the delete method, only load and refresh".format(self.__class__.__name__))

f5/bigip/tm/sys/host_info.py

@@ -0,0 +1,45 @@
+# coding=utf-8
+#
+# Copyright 2016 F5 Networks Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""BIG-IP® system host-info module
+
+REST URI
+    ``http://localhost/mgmt/tm/sys/host-info``
+
+REST Kind
+    ``tm:sys:host-info:host-infostats:*``
+"""
+
+from f5.bigip.resource import UnnamedResource
+from f5.sdk_exception import UnsupportedMethod
+
+
+class Host_Info(UnnamedResource):
+    """BIG-IP® system host info unnamed resource"""
+    def __init__(self, sys):
+        super(Host_Info, self).__init__(sys)
+        self._meta_data['object_has_stats'] = False
+        self._meta_data['required_load_parameters'] = set()
+        self._meta_data['required_json_kind'] =\
+            'tm:sys:host-info:host-infostats'
+
+    def update(self, **kwargs):
+        """Update is not supported for host info
+
+        :raises: :exc:`~f5.BIG-IP.resource.UnsupportedMethod`
+        """
+        raise UnsupportedMethod("{0} does not support the update method, only load and refresh".format(self.__class__.__name__))

f5/bigip/tm/sys/test/functional/test_application.py

@@ -30,6 +30,7 @@
     'presentation': ''
 }
 
+
 definition = {'definition': sections}
 
 

f5/bigip/tm/sys/test/functional/test_disk.py

@@ -0,0 +1,49 @@
+# Copyright 2018 F5 Networks Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+#   Unless required by applicable law or agreed to in writing, software
+#   distributed under the License is distributed on an "AS IS" BASIS,
+#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#   See the License for the specific language governing permissions and
+#   limitations under the License.
+#
+
+from f5.bigip.tm.sys.disk import Logical_Disk
+
+import pytest
+from requests import HTTPError
+
+
+class TestLogicalDisk(object):
+    def test_load_refresh(self, mgmt_root):
+        d1 = mgmt_root.tm.sys.disk.logical_disks.logical_disk.load(name='HD1')
+        assert d1.name == 'HD1'
+        assert d1.kind == 'tm:sys:disk:logical-disk:logical-diskstate'
+        assert d1.mode == 'mixed'
+
+        d2 = mgmt_root.tm.sys.disk.logical_disks.logical_disk.load(name='HD1')
+        assert d2.name == d1.name
+        assert d2.kind == d1.kind
+        assert d2.mode == d1.mode
+
+        d1.refresh()
+        assert d1.name == d2.name
+        assert d1.kind == d2.kind
+        assert d1.mode == d2.mode
+
+    def test_load_no_object(self, mgmt_root):
+        rc = mgmt_root.tm.sys.disk.logical_disks
+        with pytest.raises(HTTPError) as err:
+            rc.logical_disk.load(name='not_exists')
+        assert err.value.response.status_code == 404
+
+    def test_logical_disks_collection(self, mgmt_root):
+        rc = mgmt_root.tm.sys.disk.logical_disks.get_collection()
+        assert isinstance(rc, list)
+        assert len(rc)
+        assert isinstance(rc[0], Logical_Disk)

f5/bigip/tm/sys/test/functional/test_host_info.py

@@ -0,0 +1,37 @@
+# Copyright 2018 F5 Networks Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+#   Unless required by applicable law or agreed to in writing, software
+#   distributed under the License is distributed on an "AS IS" BASIS,
+#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#   See the License for the specific language governing permissions and
+#   limitations under the License.
+#
+
+from f5.bigip.tm.sys.host_info import Host_Info
+
+
+class TestHostInfo(object):
+    def test_load_refresh(self, mgmt_root):
+        h1 = mgmt_root.tm.sys.host_info.load()
+        assert isinstance(h1, Host_Info)
+        assert hasattr(h1, 'entries')
+        assert h1.kind == 'tm:sys:host-info:host-infostats'
+        assert 'https://localhost/mgmt/tm/sys/host-info/0' in h1.entries.keys()
+
+        h2 = mgmt_root.tm.sys.host_info.load()
+
+        assert isinstance(h2, Host_Info)
+        assert hasattr(h2, 'entries')
+        assert h2.kind == 'tm:sys:host-info:host-infostats'
+        assert 'https://localhost/mgmt/tm/sys/host-info/0' in h2.entries.keys()
+
+        h1.refresh()
+
+        assert h1.kind == h2.kind
+        assert h1.entries.keys() == h2.entries.keys()

f5/bigip/tm/sys/test/unit/test_disk.py

@@ -0,0 +1,59 @@
+# Copyright 2018 F5 Networks Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+import mock
+import pytest
+
+from f5.bigip import ManagementRoot
+from f5.bigip.resource import OrganizingCollection
+from f5.bigip.tm.sys.disk import Logical_Disk
+from f5.sdk_exception import UnsupportedMethod
+
+
+@pytest.fixture
+def fake_disk():
+    fake_oc = mock.MagicMock()
+    return Logical_Disk(fake_oc)
+
+
+class TestDiskOC(object):
+    def test_oc(self, fakeicontrolsession):
+        b = ManagementRoot('192.168.1.1', 'admin', 'admin')
+        d1 = b.tm.sys.disk
+        assert isinstance(d1, OrganizingCollection)
+        assert hasattr(d1, 'logical_disks')
+
+
+class TestLogicalDisk(object):
+    def test_logical_disk_update_raises(self, fake_disk):
+        with pytest.raises(UnsupportedMethod) as EIO:
+            fake_disk.update()
+        assert str(EIO.value) == "Logical_Disk does not support the update method, only load and refresh"
+
+    def test_logical_disk_create_raises(self, fake_disk):
+        with pytest.raises(UnsupportedMethod) as EIO:
+            fake_disk.create()
+        assert str(EIO.value) == "Logical_Disk does not support the create method, only load and refresh"
+
+    def test_logical_disk_modify_raises(self, fake_disk):
+        with pytest.raises(UnsupportedMethod) as EIO:
+            fake_disk.modify()
+        assert str(EIO.value) == "Logical_Disk does not support the modify method, only load and refresh"
+
+    def test_logical_disk_delete_raises(self, fake_disk):
+        with pytest.raises(UnsupportedMethod) as EIO:
+            fake_disk.delete()
+        assert str(EIO.value) == "Logical_Disk does not support the delete method, only load and refresh"