Skip to content

Commit 2aad5b4

Browse files
committed
Added fixes for: #489 and #490
1 parent 05a3d8d commit 2aad5b4

3 files changed

Lines changed: 15 additions & 3 deletions

File tree

f5/bigip/tm/shared/bigip_failover_state.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
"""
2828

2929
from f5.bigip.mixins import UnnamedResourceMixin
30+
from f5.bigip.mixins import UnsupportedMethod
3031
from f5.bigip.resource import ResourceBase
3132

3233

@@ -47,12 +48,13 @@ def __init__(self, shared):
4748
super(Bigip_Failover_State, self).__init__(shared)
4849
self._meta_data['required_load_parameters'] = set()
4950
self._meta_data['required_json_kind'] = ''
51+
self._meta_data['supported_versions'].discard('11.6.0')
5052

5153
def update(self, **kwargs):
5254
'''Update is not supported for BIG-IP® failover state.
5355
5456
:raises: UnsupportedOperation
5557
'''
56-
raise self.UnsupportedMethod(
58+
raise UnsupportedMethod(
5759
"%s does not support the update method" % self.__class__.__name__
5860
)

test/functional/cm/test_device_group.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@
1313
# limitations under the License.
1414
#
1515

16+
import pytest
1617
from requests import HTTPError
1718

19+
1820
TEST_DESCR = "TEST DESCRIPTION"
1921

2022

@@ -67,7 +69,9 @@ def test_add_device(self, request, bigip):
6769
d1 = dg1.devices_s.devices.create(
6870
name=this_device.name, partition=this_device.partition)
6971
assert len(dg1.devices_s.get_collection()) == 1
70-
assert d1.name == this_device.name
72+
# This needs to be in this format due to the change between
73+
# 11.6.0 Final and other versions.
74+
assert this_device.name in d1.name
7175

7276
def test_cm_sync_to_group(self, request, bigip):
7377
dg1, dgs = setup_device_group_test(
@@ -76,6 +80,10 @@ def test_cm_sync_to_group(self, request, bigip):
7680
cm_obj = bigip.cm.exec_cmd('run', utilCmdArgs=sync_cmd)
7781
assert cm_obj.utilCmdArgs == sync_cmd
7882

83+
84+
@pytest.mark.skipif(pytest.config.getoption('--release') == '12.0.0',
85+
reason='Behavior change in v12, causing this to fail')
86+
class TestSyncFromGroup(object):
7987
def test_cm_sync_from_group(self, request, bigip):
8088
dg1, dgs = setup_device_group_test(
8189
request, bigip, name='test-group', partition='Common')

test/functional/tm/sys/test_httpd.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ def cleaner(request, bigip):
2121
initial_httpd = bigip.sys.httpd.load()
2222

2323
def teardown():
24-
initial_httpd.update()
24+
# There is a difference in 11.6.0 and 12.0.0 default for max clients.
25+
# Added explicit maxClient to facilitate this change.
26+
initial_httpd.update(maxClients=10)
2527
request.addfinalizer(teardown)
2628

2729

0 commit comments

Comments
 (0)