Skip to content

Commit 31cc5fb

Browse files
committed
Fixes # 637 bugfix.datagroup_tests - added version check for update methods on dg file and ltm resources
1 parent 234479c commit 31cc5fb

2 files changed

Lines changed: 16 additions & 0 deletions

File tree

f5/bigip/tm/ltm/data_group.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
``tm:ltm:data-group*``
2727
"""
2828

29+
from distutils.version import LooseVersion
2930
from f5.bigip.resource import Collection
3031
from f5.bigip.resource import OrganizingCollection
3132
from f5.bigip.resource import Resource
@@ -87,3 +88,10 @@ def __init__(self, externals):
8788
self._meta_data['required_creation_parameters'].update(
8889
('name', 'externalFileName')
8990
)
91+
92+
def update(self, **kwargs):
93+
if LooseVersion(self._meta_data['bigip']._meta_data['tmos_version']) \
94+
< LooseVersion('11.6.0'):
95+
if 'externalFileName' in self.__dict__:
96+
del self.__dict__['externalFileName']
97+
return self._update(**kwargs)

f5/bigip/tm/sys/file.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
``tm:sys:file:*``
2727
"""
2828

29+
from distutils.version import LooseVersion
2930
from f5.bigip.resource import Collection
3031
from f5.bigip.resource import OrganizingCollection
3132
from f5.bigip.resource import Resource
@@ -68,6 +69,13 @@ def modify(self, **kwargs):
6869
raise UnsupportedMethod(
6970
"%s does not support the update method" % self.__class__.__name__)
7071

72+
def update(self, **kwargs):
73+
if LooseVersion(self._meta_data['bigip']._meta_data['tmos_version']) \
74+
< LooseVersion('11.6.0'):
75+
if 'type' in self.__dict__:
76+
del self.__dict__['type']
77+
return self._update(**kwargs)
78+
7179

7280
class Ifiles(Collection):
7381
def __init__(self, File):

0 commit comments

Comments
 (0)