Skip to content

Commit 43ae225

Browse files
committed
Fixes #315
Problem: Adds internal/external data-group support Update: Fixes for style problems
1 parent d915b0f commit 43ae225

3 files changed

Lines changed: 13 additions & 5 deletions

File tree

f5/bigip/tm/ltm/data_group.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
``tm:ltm:data-group*``
2727
"""
2828

29-
from f5.bigip.resource import OrganizingCollection
3029
from f5.bigip.resource import Collection
30+
from f5.bigip.resource import OrganizingCollection
3131
from f5.bigip.resource import Resource
3232

3333

@@ -58,7 +58,9 @@ def __init__(self, internals):
5858
super(Internal, self).__init__(internals)
5959
self._meta_data['required_json_kind'] = \
6060
u'tm:ltm:data-group:internal:internalstate'
61-
self._meta_data['required_creation_parameters'].update(('name', 'type', 'records'))
61+
self._meta_data['required_creation_parameters'].update(
62+
('name', 'type', 'records')
63+
)
6264

6365
def update(self, **kwargs):
6466
if 'type' in self.__dict__:
@@ -82,4 +84,6 @@ def __init__(self, externals):
8284
super(External, self).__init__(externals)
8385
self._meta_data['required_json_kind'] =\
8486
u'tm:ltm:data-group:external:externalstate'
85-
self._meta_data['required_creation_parameters'].update(('name', 'externalFileName'))
87+
self._meta_data['required_creation_parameters'].update(
88+
('name', 'externalFileName')
89+
)

f5/bigip/tm/ltm/test/test_datagroup.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919

2020
from f5.bigip import ManagementRoot
2121
from f5.bigip.resource import MissingRequiredCreationParameter
22-
from f5.bigip.tm.ltm.data_group import Internal, External
22+
from f5.bigip.tm.ltm.data_group import External
23+
from f5.bigip.tm.ltm.data_group import Internal
2324

2425

2526
@pytest.fixture
@@ -28,6 +29,7 @@ def FakeData_Group_Internal():
2829
fake_dg = Internal(fake_dg)
2930
return fake_dg
3031

32+
3133
@pytest.fixture
3234
def FakeData_Group_External():
3335
fake_dg = mock.MagicMock()

f5/bigip/tm/sys/file.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,4 +54,6 @@ def __init__(self, data_groups):
5454
super(Data_Group, self).__init__(data_groups)
5555
self._meta_data['required_json_kind'] =\
5656
u'tm:sys:file:data-group:data-groupstate'
57-
self._meta_data['required_creation_parameters'].update(('name', 'sourcePath', 'type'))
57+
self._meta_data['required_creation_parameters'].update(
58+
('name', 'sourcePath', 'type')
59+
)

0 commit comments

Comments
 (0)