During functional testing against 11.5.4,

test/functional/tm/ltm/test_virtual.py test fails

Issues:
Fixes #589

Problem:
A profile cannot be created or loaded on 11.5.4 under a virtual without
specifying the partition.

Analysis:
Added a tmos version check in the __init__ of the Profiles resource
under Virtual. If the tmos version is less than 11.6.0, the partition is
required for creation and load.

Tests:
Virtual tests pass against 11.5.4 and 11.6.0

Author: Paul Breaux

f5/bigip/tm/ltm/virtual.py

@@ -30,6 +30,8 @@
 from f5.bigip.resource import Collection
 from f5.bigip.resource import Resource
 
+from distutils.version import LooseVersion
+
 
 class Virtuals(Collection):
     """BIG-IP® LTM virtual collection"""
@@ -55,6 +57,14 @@ class Profiles(Resource):
     def __init__(self, Profiles_s):
         '''Autogenerated constructor.'''
         super(Profiles, self).__init__(Profiles_s)
+        if LooseVersion(self._meta_data['bigip']._meta_data['tmos_version']) \
+                < LooseVersion('11.6.0'):
+            self._meta_data['required_creation_parameters'].update(
+                ('partition',)
+            )
+            self._meta_data['required_load_parameters'].update(
+                ('partition',)
+            )
         self._meta_data['template_generated'] = True
         self._meta_data['required_json_kind'] =\
             u"tm:ltm:virtual:profiles:profilesstate"

test/functional/tm/ltm/test_virtual.py

@@ -13,6 +13,9 @@
 # limitations under the License.
 #
 
+from f5.bigip.resource import MissingRequiredCreationParameter
+from f5.bigip.resource import MissingRequiredReadParameter
+
 from distutils.version import LooseVersion
 from pprint import pprint as pp
 import pytest
@@ -25,19 +28,23 @@ def delete_resource(resources):
         resource.delete()
 
 
-def setup_virtual_test(request, bigip, partition, name):
+def setup_virtual_test(request, mgmt_root, partition, name):
     def teardown():
         delete_resource(vc1)
     request.addfinalizer(teardown)
-    vc1 = bigip.ltm.virtuals
+    vc1 = mgmt_root.tm.ltm.virtuals
     pp('****')
     virtual1 = vc1.virtual.create(name=name, partition=partition)
     return virtual1, vc1
 
 
 class TestVirtual(object):
-    def test_virtual_create_refresh_update_delete_load(self, request, bigip):
-        virtual1, vc1 = setup_virtual_test(request, bigip, 'Common', 'vstest1')
+    def test_virtual_create_refresh_update_delete_load(
+            self, request, mgmt_root, setup_device_snapshot
+    ):
+        virtual1, vc1 = setup_virtual_test(
+            request, mgmt_root, 'Common', 'vstest1'
+        )
         assert virtual1.name == 'vstest1'
         virtual1.description = TESTDESCRIPTION
         virtual1.update()
@@ -49,19 +56,20 @@ def test_virtual_create_refresh_update_delete_load(self, request, bigip):
         assert virtual2.selfLink == virtual1.selfLink
 
 
-@pytest.mark.skipif(LooseVersion(pytest.config.getoption('--release')) <
-                    LooseVersion('11.6.0'),
-                    reason='This test fails in 11.5.4. Will '
-                    'revert this change in next PR.'
-                    )
-def test_profiles_CE(bigip, opt_release):
-    v1 = bigip.ltm.virtuals.virtual.create(name="tv1", partition="Common")
+@pytest.mark.skipif(
+    LooseVersion(pytest.config.getoption('--release'))
+    < LooseVersion('11.6.0'),
+    reason='Profiles do not need a partition in 11.6.0 and up.'
+)
+def test_profiles_CE_and_greater(
+        mgmt_root, opt_release, setup_device_snapshot
+):
+    v1 = mgmt_root.tm.ltm.virtuals.virtual.create(
+        name="tv1", partition="Common"
+    )
     p1 = v1.profiles_s.profiles.create(name="http")
-    pp(p1.raw)
     test_profiles_s = v1.profiles_s
-    pp(test_profiles_s.raw)
     test_profiles_s.context = 'all'
-    pp(test_profiles_s.raw)
     assert p1.selfLink ==\
         u"https://localhost/mgmt/tm/ltm/virtual/"\
         "~Common~tv1/profiles/http?ver="+opt_release
@@ -70,3 +78,39 @@ def test_profiles_CE(bigip, opt_release):
     assert p2.exists(name='http')
 
     v1.delete()
+
+
+@pytest.mark.skipif(
+    LooseVersion(pytest.config.getoption('--release'))
+    >= LooseVersion('11.6.0'),
+    reason='Profiles are created with a partition in 11.5.4.'
+)
+def test_profiles_CE_11_5_4_and_less(
+        mgmt_root, opt_release, setup_device_snapshot
+):
+    v1 = mgmt_root.tm.ltm.virtuals.virtual.create(
+        name="tv2", partition="Common"
+    )
+    # Ensure we cannot create a profile without partition in 11.5.4
+    with pytest.raises(MissingRequiredCreationParameter) as ex:
+        v1.profiles_s.profiles.create(name="http")
+    assert "Missing required params: ['partition']" in ex.value.message
+
+    # Create the profile with the partition given
+    p1 = v1.profiles_s.profiles.create(name="http", partition="Common")
+    test_profiles_s = v1.profiles_s
+    test_profiles_s.context = 'all'
+    assert p1.selfLink ==\
+        u"https://localhost/mgmt/tm/ltm/virtual/"\
+        "~Common~tv2/profiles/~Common~http?ver="+opt_release
+
+    p2 = v1.profiles_s.profiles
+    # Ensure we cannot check for existence without partition in 11.5.4
+    with pytest.raises(MissingRequiredReadParameter) as ex:
+        assert p2.exists(name='http')
+    assert "Missing required params: ['partition']" in ex.value.message
+
+    # Check for existence with partition given
+    p2.exists(name='http', partition='Common')
+
+    v1.delete()