Cluster refactors to created trusted_peer_manager.

Issues:
Fixes #400

Problem:
Structure of clustering needs some refactoring and some testing

Analysis:
Moved the cluster modules into a cluster/ directory under f5. Also
created some functional tests for these features. So we have something
to hold onto.

Tests:
Three func tests exists now. The idea is that we can create, scale up,
scale down, and teardown a cluster. We do this with a sync-failover and
sync-only cluster type and then we create a cluster, only to delete the
cluster_manager object, reinitialize with the same devices, then
teardown that existing cluster.

Author: Paul Breaux

f5/bigip/__init__.py

@@ -20,7 +20,7 @@
 from icontrol.session import iControlRESTSession
 
 from f5.bigip.cm import Cm
-from f5.bigip.resource import OrganizingCollection
+from f5.bigip.resource import PathElement
 from f5.bigip.shared import Shared
 from f5.bigip.tm.auth import Auth as TmAuth
 from f5.bigip.tm.cm import Cm as TmCm
@@ -32,7 +32,7 @@
 from f5.bigip.tm.transaction import Transactions
 
 
-class ManagementRoot(OrganizingCollection):
+class ManagementRoot(PathElement):
     """An interface to a single BIG-IP"""
     def __init__(self, hostname, username, password, **kwargs):
         timeout = kwargs.pop('timeout', 30)
@@ -53,6 +53,8 @@ def __init__(self, hostname, username, password, **kwargs):
             'local_ip': None,
             'bigip': self,
             'icontrol_version': icontrol_version,
+            'username': username,
+            'password': password
         }
 
     @property

f5/bigip/cm/__init__.py

@@ -1,6 +1,5 @@
 # coding=utf-8
 #
-"""Classes and functions for configuring BIG-IP"""
 # Copyright 2016 F5 Networks Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -15,6 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
+"""Classes and functions for configuring BIG-IP"""
 
 from f5.bigip.cm.autodeploy import Autodeploy
 from f5.bigip.resource import OrganizingCollection

f5/bigip/mixins.py

@@ -274,16 +274,16 @@ def _upload(self, filepathname, **kwargs):
 
 
 class DeviceMixin(object):
-    '''Class to manage BigIP device cluster in a general way.'''
+    '''Manage BigIP device cluster in a general way.'''
 
-    def _get_device_info(self, bigip):
+    def get_device_info(self, bigip):
         '''Get device information about a specific BigIP device.
 
         :param bigip: bigip object --- device to inspect
         :returns: bigip object
         '''
 
-        coll = bigip.cm.devices.get_collection()
+        coll = bigip.tm.cm.devices.get_collection()
         device = [device for device in coll if device.selfDevice == 'true']
         assert len(device) == 1
         return device[0]

f5/bigip/tm/sys/application.py

@@ -134,10 +134,10 @@ def _create(self, **kwargs):
             self.load(**kwargs)
             if self.kind != self._meta_data['required_json_kind']:
                 error_message = "For instances of type '%r' the corresponding"\
-                    " kind must be '%r' but creation returned JSON with kind: %r"\
-                    % (self.__class__.__name__,
-                       self._meta_data['required_json_kind'],
-                       self.kind)
+                    " kind must be '%r' but creation returned JSON with "\
+                    " kind: %r" % (self.__class__.__name__,
+                                   self._meta_data['required_json_kind'],
+                                   self.kind)
                 raise KindTypeMismatch(error_message)
 
         return self

f5/bigip/tm/sys/test/test_sys_application.py

@@ -155,7 +155,7 @@ def __init__(self, response_obj):
 
 class MockHTTPErrorResponseSuccessful(HTTPError):
     def __init__(self):
-        self.text = 'The configuration was updated successfully but could not' \
+        self.text = 'The configuration was updated successfully but could not'\
             ' be retrieved'
 
 

f5/common/pollster.py

@@ -14,15 +14,15 @@
 #
 #
 
-import functools
+from functools import wraps
 import time
 
 
 class MaximumAttemptsReached(Exception):
     pass
 
 
-def poll_by_method(method, attempts=30, interval=2):
+def poll_by_method(method, attempts=30, interval=5):
     '''Poll with a given method for a specified number of times.
 
     :param method: callable to invoke in loop -- if no exception is raised
@@ -31,13 +31,14 @@ def poll_by_method(method, attempts=30, interval=2):
     :param interval: seconds to wait before next attempt
     '''
 
-    @functools.wraps(method)
+    @wraps(method)
     def poll(*args, **kwargs):
         for attempt in range(attempts):
             try:
                 return method(*args, **kwargs)
             except Exception:
+                if attempt == attempts-1:
+                    raise
                 time.sleep(interval)
                 continue
-        raise MaximumAttemptsReached('Polled method maximum number of times')
     return poll