Add 4 FAILing unittests for modify

Author: zancas

f5/bigip/resource.py

@@ -166,6 +166,11 @@ class BooleansToReduceHaveSameValue(F5SDKError):
     pass
 
 
+class AttemptedMutationOfReadOnly(F5SDKError):
+    """Read only parameters cannot be set."""
+    pass
+
+
 class PathElement(LazyAttributeMixin):
     """Base class to represent a URI path element that does not contain data.
 

f5/bigip/test/test_resource.py

@@ -18,6 +18,7 @@
 
 from f5.bigip.resource import BooleansToReduceHaveSameValue
 from f5.bigip.resource import Collection
+from f5.bigip.resource import AttemptedMutationOfReadOnly
 from f5.bigip.resource import DeviceProvidesIncompatibleKey
 from f5.bigip.resource import ExclusiveAttributesPresent
 from f5.bigip.resource import GenerationMismatch
@@ -332,7 +333,7 @@ def test_Collection_removal(self):
         r = Resource(mock.MagicMock())
         r._meta_data['allowed_lazy_attributes'] = []
         r._meta_data['uri'] = 'URI'
-        attrs = {'put.return_value': MockResponse({u"generation": 0}),
+        attrs = {'patch.return_value': MockResponse({u"generation": 0}),
                  'get.return_value': MockResponse({u"generation": 0})}
         mock_session = mock.MagicMock(**attrs)
         r._meta_data['bigip']._meta_data = {'icr_session': mock_session}
@@ -341,51 +342,48 @@ def test_Collection_removal(self):
         assert 'contained' in r.__dict__
         r.modify(a=u"b")
         submitted = r._meta_data['bigip']. \
-            _meta_data['icr_session'].patch.call_args[1]['json']
+            _meta_data['r_session'].patch.call_args[1]['json']
 
         assert 'contained' not in submitted
 
-    def test_read_only_removal(self):
+    def test_read_only_validate(self):
         r = Resource(mock.MagicMock())
         r._meta_data['allowed_lazy_attributes'] = []
         r._meta_data['uri'] = 'URI'
         r._meta_data['read_only_attributes'] = [u"READONLY"]
-        attrs = {'put.return_value': MockResponse({u"generation": 0}),
+        attrs = {'patch.return_value': MockResponse({u"generation": 0}),
                  'get.return_value': MockResponse({u"generation": 0})}
         mock_session = mock.MagicMock(**attrs)
         r._meta_data['bigip']._meta_data = {'icr_session': mock_session}
         r.generation = 0
-        r.READONLY = True
-        assert 'READONLY' in r.__dict__
-        r.update(a=u"b")
-        submitted = r._meta_data['bigip'].\
-            _meta_data['icr_session'].put.call_args[1]['json']
-        assert 'READONLY' not in submitted
-
-    def test_reduce_boolean_removes_enabled(self, fake_rsrc):
-        fake_rsrc.update(enabled=False)
-        pos, kwargs = fake_rsrc._meta_data['bigip']._meta_data['icr_session'].put.\
-            call_args
+        with pytest.raises(AttemptedMutationOfReadOnly) as AMOROEIO:
+            r.modify(READONLY=True)
+        assert "READONLY" in AMOROEIO.value.message
+
+    def itest_reduce_boolean_removes_enabled(self, fake_rsrc):
+        fake_rsrc.modify(enabled=False)
+        pos, kwargs = fake_rsrc._meta_data['bigip'].\
+            _meta_data['icr_session'].patch.call_args
         assert kwargs['json']['disabled'] is True
         assert 'enabled' not in kwargs['json']
 
-    def test_reduce_boolean_removes_disabled(self, fake_rsrc):
-        fake_rsrc.update(disabled=False)
-        pos, kwargs = fake_rsrc._meta_data['bigip']._meta_data['icr_session'].put.\
-            call_args
+    def itest_reduce_boolean_removes_disabled(self, fake_rsrc):
+        fake_rsrc.modify(disabled=False)
+        pos, kwargs = fake_rsrc._meta_data['bigip'].\
+            _meta_data['icr_session'].patch.call_args
         assert kwargs['json']['enabled'] is True
         assert 'disabled' not in kwargs['json']
 
-    def test_reduce_boolean_removes_nothing(self, fake_rsrc):
-        fake_rsrc.update(partition='Common', name='test_create', enabled=True)
-        pos, kwargs = fake_rsrc._meta_data['bigip']._meta_data['icr_session'].put.\
-            call_args
+    def itest_reduce_boolean_removes_nothing(self, fake_rsrc):
+        fake_rsrc.modify(partition='Common', name='test_create', enabled=True)
+        pos, kwargs = fake_rsrc._meta_data['bigip'].\
+            _meta_data['icr_session'].patch.call_args
         assert kwargs['json']['enabled'] is True
         assert 'disabled' not in kwargs['json']
 
-    def test_reduce_boolean_same_value(self, fake_rsrc):
+    def itest_reduce_boolean_same_value(self, fake_rsrc):
         with pytest.raises(BooleansToReduceHaveSameValue) as ex:
-            fake_rsrc.update(
+            fake_rsrc.modify(
                 partition='Common',
                 name='test_create',
                 enabled=True,